chrome/browser/password_manager/password_store_mac.cc - Issue 2111103002: Make callers of FromUTC(Local)Exploded in chrome/ use new time API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_mac.cc

Issue 2111103002: Make callers of FromUTC(Local)Exploded in chrome/ use new time API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media_galleries/fileapi/picasa_file_util_unittest.cc ('k') | chrome/browser/ui/webui/browsing_history_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_store_mac.cc

diff --git a/chrome/browser/password_manager/password_store_mac.cc b/chrome/browser/password_manager/password_store_mac.cc

index 63dca04ff7d065131de170d116e784a6f6415846..9fb630ccd71ad12ded8ba653d43996695d4b90bd 100644

--- a/chrome/browser/password_manager/password_store_mac.cc

+++ b/chrome/browser/password_manager/password_store_mac.cc

@@ -299,8 +299,8 @@ bool TimeFromKeychainTimeString(const char* time_string_bytes,

free(time_string);

if (assignments == 6) {

- *time = base::Time::FromUTCExploded(exploded_time);

- return true;

+ if (base::Time::FromUTCExploded(exploded_time, time))

+ return true;

}

return false;

}