Make callers of FromUTC(Local)Exploded in chrome/ use new time API.

chrome/browser/password_manager/password_store_mac.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/password_store_mac.h"
 
 #include <CoreServices/CoreServices.h>
 #include <stddef.h>
 #include <set>
 #include <string>
@@ skipping 261 matching lines @@
     port_string = port_stringstream.str();
     url_components.SetPortStr(port_string);
   }
   url_components.SetPathStr(path);
 
   GURL url("http://dummy.com");  // ReplaceComponents needs a valid URL.
   return url.ReplaceComponents(url_components);
 }
 
 // Converts a Keychain time string to a Time object, returning true if
 // time_string_bytes was parsable. If the return value is false, the value of

[vabr (Chromium), 2016/07/05 10:59:53]

The last sentence of this comment ("If the return ... is unchanged.") is no
longer true, please remove it. I checked the (only) callsite and it does not
seem to rely on this promise, so just dropping the comment is OK.

[maksims (do not use this acc), 2016/07/06 09:56:49]

Done.

 // |time| is unchanged.
 bool TimeFromKeychainTimeString(const char* time_string_bytes,
                                 unsigned int byte_length,
                                 base::Time* time) {
   DCHECK(time);
 
   char* time_string = static_cast<char*>(malloc(byte_length + 1));
   memcpy(time_string, time_string_bytes, byte_length);
   time_string[byte_length] = '\0';
   base::Time::Exploded exploded_time;
   bzero(&exploded_time, sizeof(exploded_time));
   // The time string is of the form "yyyyMMddHHmmss'Z", in UTC time.
   int assignments = sscanf(time_string, "%4d%2d%2d%2d%2d%2dZ",
                            &exploded_time.year, &exploded_time.month,
                            &exploded_time.day_of_month, &exploded_time.hour,
                            &exploded_time.minute, &exploded_time.second);
   free(time_string);
 
   if (assignments == 6) {
-    *time = base::Time::FromUTCExploded(exploded_time);
-    return true;
+    if (base::Time::FromUTCExploded(exploded_time, time))
+      return true;
   }
   return false;
 }
 
 // Returns the PasswordForm Scheme corresponding to |auth_type|.
 PasswordForm::Scheme SchemeForAuthType(SecAuthenticationType auth_type) {
   switch (auth_type) {
     case kSecAuthenticationTypeHTMLForm:   return PasswordForm::SCHEME_HTML;
     case kSecAuthenticationTypeHTTPBasic:  return PasswordForm::SCHEME_BASIC;
     case kSecAuthenticationTypeHTTPDigest: return PasswordForm::SCHEME_DIGEST;
@@ skipping 1068 matching lines @@
   ScopedVector<PasswordForm> forms_with_keychain_entry;
   internal_keychain_helpers::GetPasswordsForForms(*keychain_, &database_forms,
                                                   &forms_with_keychain_entry);
 
   // Clean up any orphaned database entries.
   RemoveDatabaseForms(&database_forms);
 
   // Move the orphaned DB forms to the output parameter.
   AppendSecondToFirst(orphaned_forms, &database_forms);
 }