Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Unified Diff: components/page_load_metrics/common/page_load_timing.cc

Issue 2111073003: Update PageLoadTiming to use base::Optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@optionalbug
Patch Set: remove comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/page_load_metrics/common/page_load_timing.cc
diff --git a/components/page_load_metrics/common/page_load_timing.cc b/components/page_load_metrics/common/page_load_timing.cc
index 1c3de6553a7fe927a0490b247342d188f7ae60a2..8bda0f894d149d3ff66dfe2025649c447e70606b 100644
--- a/components/page_load_metrics/common/page_load_timing.cc
+++ b/components/page_load_metrics/common/page_load_timing.cc
@@ -31,14 +31,12 @@ bool PageLoadTiming::operator==(const PageLoadTiming& other) const {
}
bool PageLoadTiming::IsEmpty() const {
- return navigation_start.is_null() && response_start.is_zero() &&
- dom_loading.is_zero() && dom_content_loaded_event_start.is_zero() &&
- load_event_start.is_zero() && first_layout.is_zero() &&
- first_paint.is_zero() && first_text_paint.is_zero() &&
- first_image_paint.is_zero() && parse_start.is_zero() &&
- parse_stop.is_zero() &&
- parse_blocked_on_script_load_duration.is_zero() &&
- parse_blocked_on_script_load_from_document_write_duration.is_zero();
+ return navigation_start.is_null() && !response_start && !dom_loading &&
+ !dom_content_loaded_event_start && !load_event_start &&
+ !first_layout && !first_paint && !first_text_paint &&
+ !first_image_paint && !parse_start && !parse_stop &&
+ !parse_blocked_on_script_load_duration &&
+ !parse_blocked_on_script_load_from_document_write_duration;
}
PageLoadMetadata::PageLoadMetadata() {}

Powered by Google App Engine
This is Rietveld 408576698