Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Side by Side Diff: components/page_load_metrics/common/page_load_timing.cc

Issue 2111073003: Update PageLoadTiming to use base::Optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@optionalbug
Patch Set: remove comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/page_load_metrics/common/page_load_timing.h" 5 #include "components/page_load_metrics/common/page_load_timing.h"
6 6
7 namespace page_load_metrics { 7 namespace page_load_metrics {
8 8
9 PageLoadTiming::PageLoadTiming() {} 9 PageLoadTiming::PageLoadTiming() {}
10 10
(...skipping 13 matching lines...) Expand all
24 first_text_paint == other.first_text_paint && 24 first_text_paint == other.first_text_paint &&
25 first_image_paint == other.first_image_paint && 25 first_image_paint == other.first_image_paint &&
26 parse_start == other.parse_start && parse_stop == other.parse_stop && 26 parse_start == other.parse_start && parse_stop == other.parse_stop &&
27 parse_blocked_on_script_load_duration == 27 parse_blocked_on_script_load_duration ==
28 other.parse_blocked_on_script_load_duration && 28 other.parse_blocked_on_script_load_duration &&
29 parse_blocked_on_script_load_from_document_write_duration == 29 parse_blocked_on_script_load_from_document_write_duration ==
30 other.parse_blocked_on_script_load_from_document_write_duration; 30 other.parse_blocked_on_script_load_from_document_write_duration;
31 } 31 }
32 32
33 bool PageLoadTiming::IsEmpty() const { 33 bool PageLoadTiming::IsEmpty() const {
34 return navigation_start.is_null() && response_start.is_zero() && 34 return navigation_start.is_null() && !response_start && !dom_loading &&
35 dom_loading.is_zero() && dom_content_loaded_event_start.is_zero() && 35 !dom_content_loaded_event_start && !load_event_start &&
36 load_event_start.is_zero() && first_layout.is_zero() && 36 !first_layout && !first_paint && !first_text_paint &&
37 first_paint.is_zero() && first_text_paint.is_zero() && 37 !first_image_paint && !parse_start && !parse_stop &&
38 first_image_paint.is_zero() && parse_start.is_zero() && 38 !parse_blocked_on_script_load_duration &&
39 parse_stop.is_zero() && 39 !parse_blocked_on_script_load_from_document_write_duration;
40 parse_blocked_on_script_load_duration.is_zero() &&
41 parse_blocked_on_script_load_from_document_write_duration.is_zero();
42 } 40 }
43 41
44 PageLoadMetadata::PageLoadMetadata() {} 42 PageLoadMetadata::PageLoadMetadata() {}
45 43
46 bool PageLoadMetadata::operator==(const PageLoadMetadata& other) const { 44 bool PageLoadMetadata::operator==(const PageLoadMetadata& other) const {
47 return behavior_flags == other.behavior_flags; 45 return behavior_flags == other.behavior_flags;
48 } 46 }
49 47
50 } // namespace page_load_metrics 48 } // namespace page_load_metrics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698