Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: components/page_load_metrics/browser/page_load_metrics_util.h

Issue 2111073003: Update PageLoadTiming to use base::Optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@optionalbug
Patch Set: remove comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/page_load_metrics/browser/page_load_metrics_util.h
diff --git a/components/page_load_metrics/browser/page_load_metrics_util.h b/components/page_load_metrics/browser/page_load_metrics_util.h
index 66dc3aa7119f2cfc5dbba22b6032092d94ce1a78..dfeeabdb14693c1890c307db89b874bb2813f4e1 100644
--- a/components/page_load_metrics/browser/page_load_metrics_util.h
+++ b/components/page_load_metrics/browser/page_load_metrics_util.h
@@ -29,9 +29,6 @@ struct PageLoadTiming;
// If the event time delta and background time delta are equal, we still
// consider the event to be logged in the foreground histogram since any
// background specific handling would not yet have been applied to that event.
-bool WasStartedInForegroundEventInForeground(base::TimeDelta event,
- const PageLoadExtraInfo& info);
-
bool WasStartedInForegroundOptionalEventInForeground(
const base::Optional<base::TimeDelta>& event,
const PageLoadExtraInfo& info);
@@ -40,8 +37,8 @@ bool WasStartedInForegroundOptionalEventInForeground(
// - Parse started and did not complete but the entire page load duration
// happened in the foreground.
// - Parse completed and happened entirely in the foreground.
-bool WasParseInForeground(base::TimeDelta parse_start,
- base::TimeDelta parse_stop,
+bool WasParseInForeground(const base::Optional<base::TimeDelta>& parse_start,
+ const base::Optional<base::TimeDelta>& parse_stop,
const PageLoadExtraInfo& info);
} // namespace page_load_metrics

Powered by Google App Engine
This is Rietveld 408576698