Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Side by Side Diff: components/page_load_metrics/browser/page_load_metrics_util.h

Issue 2111073003: Update PageLoadTiming to use base::Optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@optionalbug
Patch Set: remove comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_PAGE_LOAD_METRICS_BROWSER_PAGE_LOAD_METRICS_UTIL_H_ 5 #ifndef COMPONENTS_PAGE_LOAD_METRICS_BROWSER_PAGE_LOAD_METRICS_UTIL_H_
6 #define COMPONENTS_PAGE_LOAD_METRICS_BROWSER_PAGE_LOAD_METRICS_UTIL_H_ 6 #define COMPONENTS_PAGE_LOAD_METRICS_BROWSER_PAGE_LOAD_METRICS_UTIL_H_
7 7
8 #include "base/metrics/histogram_macros.h" 8 #include "base/metrics/histogram_macros.h"
9 #include "base/optional.h" 9 #include "base/optional.h"
10 #include "base/time/time.h" 10 #include "base/time/time.h"
(...skipping 11 matching lines...) Expand all
22 // Returns true if: 22 // Returns true if:
23 // - We have timing information for the event. 23 // - We have timing information for the event.
24 // - The page load started while the page was in the foreground. 24 // - The page load started while the page was in the foreground.
25 // - The event occurred prior to the page being moved to the background. 25 // - The event occurred prior to the page being moved to the background.
26 // When a page is backgrounded, some events (e.g. paint) are delayed. Since 26 // When a page is backgrounded, some events (e.g. paint) are delayed. Since
27 // these data points can skew the mean, they should not be mixed with timing 27 // these data points can skew the mean, they should not be mixed with timing
28 // events that occurred in the foreground. 28 // events that occurred in the foreground.
29 // If the event time delta and background time delta are equal, we still 29 // If the event time delta and background time delta are equal, we still
30 // consider the event to be logged in the foreground histogram since any 30 // consider the event to be logged in the foreground histogram since any
31 // background specific handling would not yet have been applied to that event. 31 // background specific handling would not yet have been applied to that event.
32 bool WasStartedInForegroundEventInForeground(base::TimeDelta event,
33 const PageLoadExtraInfo& info);
34
35 bool WasStartedInForegroundOptionalEventInForeground( 32 bool WasStartedInForegroundOptionalEventInForeground(
36 const base::Optional<base::TimeDelta>& event, 33 const base::Optional<base::TimeDelta>& event,
37 const PageLoadExtraInfo& info); 34 const PageLoadExtraInfo& info);
38 35
39 // Returns true if: 36 // Returns true if:
40 // - Parse started and did not complete but the entire page load duration 37 // - Parse started and did not complete but the entire page load duration
41 // happened in the foreground. 38 // happened in the foreground.
42 // - Parse completed and happened entirely in the foreground. 39 // - Parse completed and happened entirely in the foreground.
43 bool WasParseInForeground(base::TimeDelta parse_start, 40 bool WasParseInForeground(const base::Optional<base::TimeDelta>& parse_start,
44 base::TimeDelta parse_stop, 41 const base::Optional<base::TimeDelta>& parse_stop,
45 const PageLoadExtraInfo& info); 42 const PageLoadExtraInfo& info);
46 } // namespace page_load_metrics 43 } // namespace page_load_metrics
47 44
48 #endif // COMPONENTS_PAGE_LOAD_METRICS_BROWSER_PAGE_LOAD_METRICS_UTIL_H_ 45 #endif // COMPONENTS_PAGE_LOAD_METRICS_BROWSER_PAGE_LOAD_METRICS_UTIL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698