Hide more GrBatch Geometry structs.

Hide more GrBatch Geometry structs.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2110903002

Committed: https://skia.googlesource.com/skia/+/f17030906dde79ef9debddf9d96098fcf71a6f09

[bsalomon, 2016-06-29 20:48:48]

Description was changed from

==========
Hide more GrBatch Geometry structs.
==========

to

==========
Hide more GrBatch Geometry structs.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2110903002
==========

[bsalomon, 2016-06-29 20:50:18]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[bsalomon, 2016-06-29 20:56:28]

https://codereview.chromium.org/2110903002/diff/1/src/gpu/batches/GrAAHairLin...
File src/gpu/batches/GrAAHairLinePathRenderer.cpp (right):

https://codereview.chromium.org/2110903002/diff/1/src/gpu/batches/GrAAHairLin...
src/gpu/batches/GrAAHairLinePathRenderer.cpp:682: SkPath path,
Will make this const SkPath&

[robertphillips, 2016-06-29 21:07:33]

lgtm

https://codereview.chromium.org/2110903002/diff/20001/src/gpu/batches/GrAACon...
File src/gpu/batches/GrAAConvexPathRenderer.cpp (right):

https://codereview.chromium.org/2110903002/diff/20001/src/gpu/batches/GrAACon...
src/gpu/batches/GrAAConvexPathRenderer.cpp:749: // compute bounds
Woe, it would be nice if 'fBounds' were private to GrBatch - not willing to
trade any perf for that though.

https://codereview.chromium.org/2110903002/diff/20001/src/gpu/batches/GrAADis...
File src/gpu/batches/GrAADistanceFieldPathRenderer.cpp (right):

https://codereview.chromium.org/2110903002/diff/20001/src/gpu/batches/GrAADis...
src/gpu/batches/GrAADistanceFieldPathRenderer.cpp:141:
fGeoData.emplace_back(Geometry{color, shape, antiAlias});
this assert seems redundant with the above one

https://codereview.chromium.org/2110903002/diff/20001/src/gpu/batches/GrAAHai...
File src/gpu/batches/GrAAHairLinePathRenderer.cpp (right):

https://codereview.chromium.org/2110903002/diff/20001/src/gpu/batches/GrAAHai...
src/gpu/batches/GrAAHairLinePathRenderer.cpp:680: uint8_t coverage,
const SkMatrix& ?

[bsalomon, 2016-06-29 21:12:29]

https://codereview.chromium.org/2110903002/diff/20001/src/gpu/batches/GrAACon...
File src/gpu/batches/GrAAConvexPathRenderer.cpp (right):

https://codereview.chromium.org/2110903002/diff/20001/src/gpu/batches/GrAACon...
src/gpu/batches/GrAAConvexPathRenderer.cpp:749: // compute bounds
On 2016/06/29 21:07:33, robertphillips wrote:
> Woe, it would be nice if 'fBounds' were private to GrBatch - not willing to
> trade any perf for that though.

Yep, I had the same though. Might look at it later.

https://codereview.chromium.org/2110903002/diff/20001/src/gpu/batches/GrAADis...
File src/gpu/batches/GrAADistanceFieldPathRenderer.cpp (right):

https://codereview.chromium.org/2110903002/diff/20001/src/gpu/batches/GrAADis...
src/gpu/batches/GrAADistanceFieldPathRenderer.cpp:141:
fGeoData.emplace_back(Geometry{color, shape, antiAlias});
On 2016/06/29 21:07:33, robertphillips wrote:
> this assert seems redundant with the above one

Done.

https://codereview.chromium.org/2110903002/diff/20001/src/gpu/batches/GrAAHai...
File src/gpu/batches/GrAAHairLinePathRenderer.cpp (right):

https://codereview.chromium.org/2110903002/diff/20001/src/gpu/batches/GrAAHai...
src/gpu/batches/GrAAHairLinePathRenderer.cpp:680: uint8_t coverage,
On 2016/06/29 21:07:33, robertphillips wrote:
> const SkMatrix& ?

Done.

[bsalomon, 2016-06-29 21:12:34]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-06-29 21:12:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2110903002/#ps40001
(title: "Address comments")

[commit-bot: I haz the power, 2016-06-29 21:12:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 21:12:39]

This CL has an open dependency (Issue 2104423003 Patch 40001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[bsalomon, 2016-06-30 01:24:48]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-06-30 01:24:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 01:41:55]

Description was changed from

==========
Hide more GrBatch Geometry structs.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2110903002
==========

to

==========
Hide more GrBatch Geometry structs.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2110903002

Committed:
https://skia.googlesource.com/skia/+/f17030906dde79ef9debddf9d96098fcf71a6f09
==========

[commit-bot: I haz the power, 2016-06-30 01:41:56]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/f17030906dde79ef9debddf9d96098fcf71a6f09