Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1399)

Issue 2110853002: Reland of TLS CECPQ1 (experimental post-quantum) ciphers. (Closed)

Created:
4 years, 5 months ago by Pete Williamson
Modified:
4 years, 5 months ago
Reviewers:
agl, davidben, mab
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of TLS CECPQ1 (experimental post-quantum) ciphers. (patchset #1 id:1 of https://codereview.chromium.org/2107273002/ ) Reason for revert: Sheriff is reverting this patchset on suspicion of adding a new static constructor (string) causing a failure of the "sizes" step of the build. Link to broken build: https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/21618 Relevant log lines: FAILED linux-release-64/sizes/chrome-si/initializers: actual 9, expected 7, better lower Original issue's description: > Revert of TLS CECPQ1 (experimental post-quantum) ciphers. (patchset #6 id:100001 of https://codereview.chromium.org/2101283004/ ) > > Reason for revert: > CroNet does not setup FeatureList. See https://bugs.chromium.org/p/chromium/issues/detail?id=624370 > > Original issue's description: > > TLS CECPQ1 (experimental post-quantum) ciphers. > > > > These exeperimental and non-standard ciphers are an experiment in > > post-quantum key exchange for TLS only (not QUIC). They are not > > intended as a de facto standard and will be removed from Chrome in a > > year or two. > > > > The key exchange performs a New Hope (post-quantum) and X25519 key > > exchange in parallel, using the outputs of both to generate the > > pre-master secret. > > > > BUG= > > > > Committed: https://crrev.com/7346da96d0fb2651d5b28912572e57dd20e10874 > > Cr-Commit-Position: refs/heads/master@{#402705} > > TBR=davidben@chromium.org,mab@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://crrev.com/790d5c8eeb83f84ad6d876d77e240375d84e83e3 > Cr-Commit-Position: refs/heads/master@{#402828} TBR=davidben@chromium.org,mab@google.com,agl@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/ec5f5df22dd58d9da94b74633ba53c8ded550806 Cr-Commit-Position: refs/heads/master@{#402849}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -2 lines) Patch
M net/socket/ssl_client_socket_impl.cc View 3 chunks +29 lines, -2 lines 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Pete Williamson
Created Reland of TLS CECPQ1 (experimental post-quantum) ciphers.
4 years, 5 months ago (2016-06-29 17:19:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110853002/1
4 years, 5 months ago (2016-06-29 17:20:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 17:21:49 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 17:21:51 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ec5f5df22dd58d9da94b74633ba53c8ded550806 Cr-Commit-Position: refs/heads/master@{#402849}
4 years, 5 months ago (2016-06-29 17:25:42 UTC) #8
agl
4 years, 5 months ago (2016-06-29 17:29:18 UTC) #9
Message was sent while issue was closed.
LGTM

It seems unlikely that reverting this revert will improve anything :) None the
less we were just discussing whether to reland it so I'll take it!

Powered by Google App Engine
This is Rietveld 408576698