Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in

Issue 2107273002: Revert of TLS CECPQ1 (experimental post-quantum) ciphers. (Closed)

4 years ago by agl
4 years ago
davidben, mab
Base URL:
Target Ref:


Revert of TLS CECPQ1 (experimental post-quantum) ciphers. (patchset #6 id:100001 of ) Reason for revert: CroNet does not setup FeatureList. See Original issue's description: > TLS CECPQ1 (experimental post-quantum) ciphers. > > These exeperimental and non-standard ciphers are an experiment in > post-quantum key exchange for TLS only (not QUIC). They are not > intended as a de facto standard and will be removed from Chrome in a > year or two. > > The key exchange performs a New Hope (post-quantum) and X25519 key > exchange in parallel, using the outputs of both to generate the > pre-master secret. > > BUG= > > Committed: > Cr-Commit-Position: refs/heads/master@{#402705}, # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: Cr-Commit-Position: refs/heads/master@{#402828}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -31 lines) Patch
M net/socket/ View 3 chunks +2 lines, -29 lines 0 comments Download
M net/socket/ View 1 chunk +0 lines, -2 lines 0 comments Download


Total messages: 8 (2 generated)
Created Revert of TLS CECPQ1 (experimental post-quantum) ciphers.
4 years ago (2016-06-29 16:07:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at
4 years ago (2016-06-29 16:08:04 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-06-29 16:08:52 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked.
4 years ago (2016-06-29 16:09:07 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as Cr-Commit-Position: refs/heads/master@{#402828}
4 years ago (2016-06-29 16:11:41 UTC) #7
Pete Williamson
4 years ago (2016-06-29 17:19:18 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in by

The reason for reverting is: Sheriff is reverting this patchset on suspicion of
adding a new static constructor (string) causing a failure of the "sizes" step
of the build.

Link to broken build:

Relevant log lines:
FAILED linux-release-64/sizes/chrome-si/initializers: actual 9, expected 7,
better lower

Powered by Google App Engine
This is Rietveld 408576698