Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(100)

Issue 2107273002: Revert of TLS CECPQ1 (experimental post-quantum) ciphers. (Closed)

Created:
4 years ago by agl
Modified:
4 years ago
Reviewers:
davidben, mab
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of TLS CECPQ1 (experimental post-quantum) ciphers. (patchset #6 id:100001 of https://codereview.chromium.org/2101283004/ ) Reason for revert: CroNet does not setup FeatureList. See https://bugs.chromium.org/p/chromium/issues/detail?id=624370 Original issue's description: > TLS CECPQ1 (experimental post-quantum) ciphers. > > These exeperimental and non-standard ciphers are an experiment in > post-quantum key exchange for TLS only (not QUIC). They are not > intended as a de facto standard and will be removed from Chrome in a > year or two. > > The key exchange performs a New Hope (post-quantum) and X25519 key > exchange in parallel, using the outputs of both to generate the > pre-master secret. > > BUG= > > Committed: https://crrev.com/7346da96d0fb2651d5b28912572e57dd20e10874 > Cr-Commit-Position: refs/heads/master@{#402705} TBR=davidben@chromium.org,mab@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/790d5c8eeb83f84ad6d876d77e240375d84e83e3 Cr-Commit-Position: refs/heads/master@{#402828}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -31 lines) Patch
M net/socket/ssl_client_socket_impl.cc View 3 chunks +2 lines, -29 lines 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
agl
Created Revert of TLS CECPQ1 (experimental post-quantum) ciphers.
4 years ago (2016-06-29 16:07:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2107273002/1
4 years ago (2016-06-29 16:08:04 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-06-29 16:08:52 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked.
4 years ago (2016-06-29 16:09:07 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/790d5c8eeb83f84ad6d876d77e240375d84e83e3 Cr-Commit-Position: refs/heads/master@{#402828}
4 years ago (2016-06-29 16:11:41 UTC) #7
Pete Williamson
4 years ago (2016-06-29 17:19:18 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2110853002/ by petewil@chromium.org.

The reason for reverting is: Sheriff is reverting this patchset on suspicion of
adding a new static constructor (string) causing a failure of the "sizes" step
of the build.

Link to broken build:
https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/21618

Relevant log lines:
FAILED linux-release-64/sizes/chrome-si/initializers: actual 9, expected 7,
better lower
.

Powered by Google App Engine
This is Rietveld 408576698