MD Settings: Add mouse settings, update pointer settings

chrome/browser/resources/settings/device_page/pointers.html

Index: chrome/browser/resources/settings/device_page/pointers.html
diff --git a/chrome/browser/resources/settings/device_page/pointers.html b/chrome/browser/resources/settings/device_page/pointers.html
new file mode 100644
index 0000000000000000000000000000000000000000..3f56e8e276cb7dd4ed1e77eb103cb3437192354a
--- /dev/null
+++ b/chrome/browser/resources/settings/device_page/pointers.html
@@ -0,0 +1,84 @@
+<link rel="import" href="chrome://resources/html/polymer.html">
+<link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/paper-radio-button/paper-radio-button.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/paper-slider/paper-slider.html">
+<link rel="import" href="chrome://md-settings/controls/settings_checkbox.html">
+<link rel="import" href="chrome://md-settings/controls/settings_radio_group.html">
+<link rel="import" href="chrome://md-settings/settings_shared_css.html">
+
+<dom-module id="settings-pointers">
+  <template>
+    <style include="settings-shared">
+      .subsection > * {
+        -webkit-padding-end: 20px;
+        -webkit-padding-start: 56px;
+      }
+
+      .subsection h2 {
+        padding: 0 20px;
+      }
+    </style>
+    <div id="mouse" hidden$="[[!hasMouse]]"
+        class$="[[getSectionClass_(hasMouse, hasTouchpad)]]">
+      <!-- Subsection title only appears if both mouse and touchpad exist. -->
+      <h2 hidden$="[[!hasTouchpad]]">$i18n{mouseTitle}</h2>
+      <div class="settings-box first">
+        <settings-checkbox pref="{{prefs.settings.mouse.primary_right}}"
+            label="$i18n{mouseSwapButtons}">
+        </settings-checkbox>
+      </div>
+      <div class="settings-box">
+        <div class="start" id="mouseSpeedLabel">$i18n{mouseSpeed}</div>
+        <div class="layout horizontal center">
+          <div>$i18n{pointerSlow}</div>
+          <paper-slider id="mouseSensitivity" class="always-on" snaps
+              min="1" max="5" aria-labelledby="mouseSpeedLabel"
+              value="{{prefs.settings.mouse.sensitivity2.value}}">
+          </paper-slider>
+          <div>$i18n{pointerFast}</div>
+        </div>
+      </div>
+    </div>
+    <div id="touchpad" hidden$="[[!hasTouchpad]]"
+        class$="[[getSectionClass_(hasMouse, hasTouchpad)]]">
+      <!-- Subsection title only appears if both mouse and touchpad exist. -->
+      <h2 hidden$="[[!hasMouse]]">$i18n{touchpadTitle}</h2>
+      <div class="settings-box block first">
+        <settings-checkbox pref="{{prefs.settings.touchpad.enable_tap_to_click}}"

[stevenjb, 2016/06/30 00:07:49]

nit: pref= on next line here and on line 50

[michaelpg, 2016/07/09 04:11:30]

Done.

+            label="$i18n{touchpadTapToClickEnabledLabel}">
+        </settings-checkbox>
+        <settings-checkbox pref="{{prefs.settings.touchpad.enable_tap_dragging}}"
+            label="$i18n{tapDraggingLabel}">
+        </settings-checkbox>
+      </div>
+      <div class="settings-box">
+        <div class="start" id="touchpadSpeedLabel">$i18n{touchpadSpeed}</div>
+        <div class="layout horizontal center">
+          <div>$i18n{pointerSlow}</div>
+          <paper-slider id="touchpadSensitivity" class="always-on" snaps
+              min="1" max="5" aria-labelledby="touchpadSpeedLabel"
+              value="{{prefs.settings.touchpad.sensitivity2.value}}">
+          </paper-slider>
+          <div>$i18n{pointerFast}</div>
+        </div>
+      </div>
+      <div class="settings-box">$i18n{scrollLabel}</div>
+      <div class="list-frame">
+        <settings-radio-group pref="{{prefs.settings.touchpad.natural_scroll}}">
+          <paper-radio-button name="false">
+            $i18n{traditionalScrollLabel}
+          </paper-radio-button>
+          <paper-radio-button name="true">
+            $i18n{naturalScrollLabel}
+            <a href="$i18n{naturalScrollLearnMoreLink}" target="_blank"
+                on-tap="onLearnMoreLinkActivated_"
+                on-keydown="onLearnMoreLinkActivated_">

[stevenjb, 2016/06/30 00:07:49]

I don't see on-keydown used elsewhere, any particular reason to use it just
here?

[michaelpg, 2016/07/09 04:11:30]

this is moved from touchpad.html which was reviewed a while ago by dbeam. it
prevents the link from activating the radio button:
https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/device...

+              $i18n{naturalScrollLearnMore}
+            </a>
+          </paper-radio-button>
+        </settings-radio-group>
+      </div>
+    </div>
+  </template>
+  <script src="pointers.js"></script>
+</dom-module>