chrome/browser/resources/settings/device_page/pointers.html - Issue 2110833003: MD Settings: Add mouse settings, update pointer settings

Side by Side Diff: chrome/browser/resources/settings/device_page/pointers.html

Issue 2110833003: MD Settings: Add mouse settings, update pointer settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@PointersFake

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/device_page/device_page.js ('K') | « chrome/browser/resources/settings/device_page/device_page_browser_proxy.js ('k') | chrome/browser/resources/settings/device_page/pointers.js » ('j') | chrome/browser/ui/webui/settings/chromeos/device_pointer_handler.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/html/polymer.html">

	2 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html">

	3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-radio-button/pape r-radio-button.html">

	4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-slider/paper-slid er.html">

	5 <link rel="import" href="chrome://md-settings/controls/settings_checkbox.html">

	6 <link rel="import" href="chrome://md-settings/controls/settings_radio_group.html ">

	7 <link rel="import" href="chrome://md-settings/settings_shared_css.html">

	8

	9 <dom-module id="settings-pointers">

	10 <template>

	11 <style include="settings-shared">

	12 .subsection > * {

	13 -webkit-padding-end: 20px;

	14 -webkit-padding-start: 56px;

	15 }

	16

	17 .subsection h2 {

	18 padding: 0 20px;

	19 }

	20 </style>

	21 <div id="mouse" hidden$="[[!hasMouse]]"

	22 class$="[[getSectionClass_(hasMouse, hasTouchpad)]]">

	23 <!-- Subsection title only appears if both mouse and touchpad exist. -->

	24 <h2 hidden$="[[!hasTouchpad]]">$i18n{mouseTitle}</h2>

	25 <div class="settings-box first">

	26 <settings-checkbox pref="{{prefs.settings.mouse.primary_right}}"

	27 label="$i18n{mouseSwapButtons}">

	28 </settings-checkbox>

	29 </div>

	30 <div class="settings-box">

	31 <div class="start" id="mouseSpeedLabel">$i18n{mouseSpeed}</div>

	32 <div class="layout horizontal center">

	33 <div>$i18n{pointerSlow}</div>

	34 <paper-slider id="mouseSensitivity" class="always-on" snaps

	35 min="1" max="5" aria-labelledby="mouseSpeedLabel"

	36 value="{{prefs.settings.mouse.sensitivity2.value}}">

	37 </paper-slider>

	38 <div>$i18n{pointerFast}</div>

	39 </div>

	40 </div>

	41 </div>

	42 <div id="touchpad" hidden$="[[!hasTouchpad]]"

	43 class$="[[getSectionClass_(hasMouse, hasTouchpad)]]">

	44 <!-- Subsection title only appears if both mouse and touchpad exist. -->

	45 <h2 hidden$="[[!hasMouse]]">$i18n{touchpadTitle}</h2>

	46 <div class="settings-box block first">

	47 <settings-checkbox pref="{{prefs.settings.touchpad.enable_tap_to_click}} "
	stevenjb 2016/06/30 00:07:49 nit: pref= on next line here and on line 50 nit: pref= on next line here and on line 50 michaelpg 2016/07/09 04:11:30 Done. Show quoted text On 2016/06/30 00:07:49, stevenjb wrote: > nit: pref= on next line here and on line 50 Done.
	48 label="$i18n{touchpadTapToClickEnabledLabel}">

	49 </settings-checkbox>

	50 <settings-checkbox pref="{{prefs.settings.touchpad.enable_tap_dragging}} "

	51 label="$i18n{tapDraggingLabel}">

	52 </settings-checkbox>

	53 </div>

	54 <div class="settings-box">

	55 <div class="start" id="touchpadSpeedLabel">$i18n{touchpadSpeed}</div>

	56 <div class="layout horizontal center">

	57 <div>$i18n{pointerSlow}</div>

	58 <paper-slider id="touchpadSensitivity" class="always-on" snaps

	59 min="1" max="5" aria-labelledby="touchpadSpeedLabel"

	60 value="{{prefs.settings.touchpad.sensitivity2.value}}">

	61 </paper-slider>

	62 <div>$i18n{pointerFast}</div>

	63 </div>

	64 </div>

	65 <div class="settings-box">$i18n{scrollLabel}</div>

	66 <div class="list-frame">

	67 <settings-radio-group pref="{{prefs.settings.touchpad.natural_scroll}}">

	68 <paper-radio-button name="false">

	69 $i18n{traditionalScrollLabel}

	70 </paper-radio-button>

	71 <paper-radio-button name="true">

	72 $i18n{naturalScrollLabel}

	73 <a href="$i18n{naturalScrollLearnMoreLink}" target="_blank"

	74 on-tap="onLearnMoreLinkActivated_"

	75 on-keydown="onLearnMoreLinkActivated_">
	stevenjb 2016/06/30 00:07:49 I don't see on-keydown used elsewhere, any particu I don't see on-keydown used elsewhere, any particular reason to use it just here? michaelpg 2016/07/09 04:11:30 this is moved from touchpad.html which was reviewe Show quoted text On 2016/06/30 00:07:49, stevenjb wrote: > I don't see on-keydown used elsewhere, any particular reason to use it just > here? this is moved from touchpad.html which was reviewed a while ago by dbeam. it prevents the link from activating the radio button: https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/device...
	76 $i18n{naturalScrollLearnMore}

	77 </a>

	78 </paper-radio-button>

	79 </settings-radio-group>

	80 </div>

	81 </div>

	82 </template>

	83 <script src="pointers.js"></script>

	84 </dom-module>

OLD	NEW