Rename functions in Port related to wptserve and add a helper function.

Rename functions in Port related to wptserve and add a helper function.

This is a refactoring CL which should cause no behavior changes.

In this CL:
 (1) Rename is_wpt_enabled -> is_wptserve_enabled
 (2) Rename is_wpt_test -> is_wptserve_test
 (3) Add should_use_wptserve (= is_wptserve enabled and is_wptserve_test).

The rational for (2) is that many (most) tests in imported/wpt behave the
same if they're run with wptserve and with file://; only a smallish number
of the tests behave differently. It may be faster to run the tests if we
only use wptserve for the tests that require it; so later we may want
to change is_wptserve_test to check some things, e.g. wptserve header
files in the directory; or ".http." or ".https."  in the file name.

BUG=618366
Committed: https://crrev.com/489b7e668259f3e433af13eae79a018bc78beca1
Cr-Commit-Position: refs/heads/master@{#402997}

[qyearsley, 2016-06-29 18:01:41]

qyearsley@chromium.org changed reviewers:
+ rbyers@chromium.org

[Rick Byers, 2016-06-29 18:28:03]

LGTM

[qyearsley, 2016-06-29 20:39:33]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2016-06-29 20:40:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 23:40:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-29 23:40:53]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-29 23:43:03]

Description was changed from

==========
Rename functions in Port related to wptserve and add a helper function.

This is a refactoring CL which should cause no behavior changes.

In this CL:
 (1) Rename is_wpt_enabled -> is_wptserve_enabled
 (2) Rename is_wpt_test -> is_wptserve_test
 (3) Add should_use_wptserve (= is_wptserve enabled and is_wptserve_test).

The rational for (2) is that many (most) tests in imported/wpt behave the
same if they're run with wptserve and with file://; only a smallish number
of the tests behave differently. It may be faster to run the tests if we
only use wptserve for the tests that require it; so later we may want
to change is_wptserve_test to check some things, e.g. wptserve header
files in the directory; or ".http." or ".https."  in the file name.

BUG=618366
==========

to

==========
Rename functions in Port related to wptserve and add a helper function.

This is a refactoring CL which should cause no behavior changes.

In this CL:
 (1) Rename is_wpt_enabled -> is_wptserve_enabled
 (2) Rename is_wpt_test -> is_wptserve_test
 (3) Add should_use_wptserve (= is_wptserve enabled and is_wptserve_test).

The rational for (2) is that many (most) tests in imported/wpt behave the
same if they're run with wptserve and with file://; only a smallish number
of the tests behave differently. It may be faster to run the tests if we
only use wptserve for the tests that require it; so later we may want
to change is_wptserve_test to check some things, e.g. wptserve header
files in the directory; or ".http." or ".https."  in the file name.

BUG=618366

Committed: https://crrev.com/489b7e668259f3e433af13eae79a018bc78beca1
Cr-Commit-Position: refs/heads/master@{#402997}
==========

[commit-bot: I haz the power, 2016-06-29 23:43:03]

Patchset 1 (id:??) landed as
https://crrev.com/489b7e668259f3e433af13eae79a018bc78beca1
Cr-Commit-Position: refs/heads/master@{#402997}