third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py - Issue 2110823002: Rename functions in Port related to wptserve and add a helper function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

Issue 2110823002: Rename functions in Port related to wptserve and add a helper function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

index b29a0addbdde973a3f4c9838da337ec2bee1baf7..32a2f6d1d6a304ebd8068317b2f3fe7703840308 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

@@ -230,7 +230,7 @@ class Manager(object):

return self.INSPECTOR_SUBDIR in test

def _is_websocket_test(self, test):

- if self._port.is_wpt_enabled() and self._port.is_wpt_test(test):

+ if self._port.should_use_wptserve(test):

return False

return self.WEBSOCKET_SUBDIR in test

@@ -369,7 +369,7 @@ class Manager(object):

tests_to_skip, num_workers, retry_attempt)

def _start_servers(self, tests_to_run):

- if self._port.is_wpt_enabled() and any(self._port.is_wpt_test(test) for test in tests_to_run):

+ if self._port.is_wptserve_enabled() and any(self._port.is_wptserve_test(test) for test in tests_to_run):

self._printer.write_update('Starting WPTServe ...')

self._port.start_wptserve()

self._wptserve_started = True

« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py » ('j') | no next file with comments »