Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2110813002: bluetooth: Move First Device Chooser to tests (Closed)

Created:
4 years, 5 months ago by ortuno
Modified:
4 years, 5 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, dglazkov+blink, haraken, jam, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, mlamouri+watch-content_chromium.org, ortuno+watch_chromium.org, Peter Beverloo, qsr+mojo_chromium.org, scheib+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@my-origin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Move First Device Chooser to tests Now that we have a chooser on all supported platforms we can move the First Device Chooser fallback to content shell, the only place where it's needed. BUG=524780 Committed: https://crrev.com/1045554135e81958e4340f9a2eb9fb088618e6d5 Cr-Commit-Position: refs/heads/master@{#403358}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -103 lines) Patch
M content/browser/bluetooth/bluetooth_device_chooser_controller.cc View 2 chunks +2 lines, -4 lines 0 comments Download
D content/browser/bluetooth/first_device_bluetooth_chooser.h View 1 chunk +0 lines, -39 lines 0 comments Download
D content/browser/bluetooth/first_device_bluetooth_chooser.cc View 1 chunk +0 lines, -49 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_shell.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/browser/layout_test/blink_test_controller.cc View 2 chunks +2 lines, -1 line 2 comments Download
A content/shell/browser/layout_test/layout_test_first_device_bluetooth_chooser.h View 1 chunk +41 lines, -0 lines 0 comments Download
A + content/shell/browser/layout_test/layout_test_first_device_bluetooth_chooser.cc View 3 chunks +13 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110813002/1
4 years, 5 months ago (2016-06-29 16:41:33 UTC) #2
ortuno
peter: PTAL at content/shell palmer: PTAT at t/W/p/p/m/bluetooth/web_bluetooth.mojom
4 years, 5 months ago (2016-06-29 17:58:11 UTC) #4
Peter Beverloo
//content/shell/ lgtm
4 years, 5 months ago (2016-06-29 18:45:10 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-29 19:10:50 UTC) #7
palmer
lgtm
4 years, 5 months ago (2016-06-30 00:31:32 UTC) #8
ortuno
scheib: PTAL
4 years, 5 months ago (2016-06-30 02:25:52 UTC) #10
scheib
LGTM https://codereview.chromium.org/2110813002/diff/1/content/shell/browser/layout_test/blink_test_controller.cc File content/shell/browser/layout_test/blink_test_controller.cc (right): https://codereview.chromium.org/2110813002/diff/1/content/shell/browser/layout_test/blink_test_controller.cc#newcode396 content/shell/browser/layout_test/blink_test_controller.cc:396: std::unique_ptr<BluetoothChooser> BlinkTestController::RunBluetoothChooser( Out of scope of this change, ...
4 years, 5 months ago (2016-06-30 22:18:11 UTC) #12
ortuno
https://codereview.chromium.org/2110813002/diff/1/content/shell/browser/layout_test/blink_test_controller.cc File content/shell/browser/layout_test/blink_test_controller.cc (right): https://codereview.chromium.org/2110813002/diff/1/content/shell/browser/layout_test/blink_test_controller.cc#newcode396 content/shell/browser/layout_test/blink_test_controller.cc:396: std::unique_ptr<BluetoothChooser> BlinkTestController::RunBluetoothChooser( On 2016/06/30 at 22:18:11, scheib wrote: > ...
4 years, 5 months ago (2016-06-30 22:32:36 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110813002/1
4 years, 5 months ago (2016-06-30 22:33:08 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 00:07:44 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 00:08:01 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 00:12:22 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1045554135e81958e4340f9a2eb9fb088618e6d5
Cr-Commit-Position: refs/heads/master@{#403358}

Powered by Google App Engine
This is Rietveld 408576698