components/password_manager/core/browser/credential_manager_pending_request_task.cc - Issue 2110663002: components: Change auto to not deduce raw pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/credential_manager_pending_request_task.cc

Issue 2110663002: components: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/ntp_snippets/ntp_snippets_fetcher.cc ('k') | components/password_manager/core/browser/login_database_unittest.cc » ('j') | components/password_manager/core/browser/password_manager_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/credential_manager_pending_request_task.cc

diff --git a/components/password_manager/core/browser/credential_manager_pending_request_task.cc b/components/password_manager/core/browser/credential_manager_pending_request_task.cc

index 26fb40ecd68e119ba209c1419c7bffb23f2ea8b3..fbcde71210a65d2bd292b796948f7fb68b3d1e5b 100644

--- a/components/password_manager/core/browser/credential_manager_pending_request_task.cc

+++ b/components/password_manager/core/browser/credential_manager_pending_request_task.cc

@@ -25,7 +25,7 @@ namespace {

void ReportAccountChooserMetrics(

const ScopedVector<autofill::PasswordForm>& local_results) {

std::vector<base::string16> usernames;

- for (const auto& form : local_results)

+ for (auto* form : local_results)

usernames.push_back(form->username_value);

std::sort(usernames.begin(), usernames.end());

bool has_empty_username = !usernames.empty() && usernames[0].empty();

@@ -77,7 +77,7 @@ void CredentialManagerPendingRequestTask::OnGetPasswordStoreResults(

ScopedVector<autofill::PasswordForm> local_results;

ScopedVector<autofill::PasswordForm> affiliated_results;

ScopedVector<autofill::PasswordForm> federated_results;

- for (auto& form : results) {

+ for (auto* form : results) {

// Ensure that the form we're looking at matches the password and

// federation filters provided.

if (!((form->federation_origin.unique() && include_passwords_) ||