components/ntp_snippets/ntp_snippets_fetcher.cc - Issue 2110663002: components: Change auto to not deduce raw pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/ntp_snippets_fetcher.cc

Issue 2110663002: components: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/ntp_snippets/ntp_snippet.cc ('k') | components/password_manager/core/browser/credential_manager_pending_request_task.cc » ('j') | components/password_manager/core/browser/credential_manager_pending_request_task.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/ntp_snippets_fetcher.cc

diff --git a/components/ntp_snippets/ntp_snippets_fetcher.cc b/components/ntp_snippets/ntp_snippets_fetcher.cc

index b5f8b51659da3d87649c918465b3edbe84d379a4..1c551c0b35de2a7d5efc014ea18478145ac876ec 100644

--- a/components/ntp_snippets/ntp_snippets_fetcher.cc

+++ b/components/ntp_snippets/ntp_snippets_fetcher.cc

@@ -259,7 +259,7 @@ std::string NTPSnippetsFetcher::RequestParams::BuildRequest() {

}

auto content_restricts = base::MakeUnique<base::ListValue>();

- for (const auto& metadata : {"TITLE", "SNIPPET", "THUMBNAIL"}) {

+ for (auto* metadata : {"TITLE", "SNIPPET", "THUMBNAIL"}) {

auto entry = base::MakeUnique<base::DictionaryValue>();

entry->SetString("type", "METADATA");

entry->SetString("value", metadata);