components/guest_view/browser/guest_view_message_filter.cc - Issue 2110663002: components: Change auto to not deduce raw pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/guest_view/browser/guest_view_message_filter.cc

Issue 2110663002: components: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/guest_view/browser/guest_view_manager.cc ('k') | components/keyed_service/core/dependency_manager.cc » ('j') | components/password_manager/core/browser/credential_manager_pending_request_task.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/guest_view/browser/guest_view_message_filter.cc

diff --git a/components/guest_view/browser/guest_view_message_filter.cc b/components/guest_view/browser/guest_view_message_filter.cc

index c1f65906caf0f3378df1302dbd619f69c3a9a0bf..4213918d3f9d54806fd3be941a9ba544e6714550 100644

--- a/components/guest_view/browser/guest_view_message_filter.cc

+++ b/components/guest_view/browser/guest_view_message_filter.cc

@@ -49,7 +49,7 @@ GuestViewMessageFilter::~GuestViewMessageFilter() {

}

GuestViewManager* GuestViewMessageFilter::GetOrCreateGuestViewManager() {

- auto manager = GuestViewManager::FromBrowserContext(browser_context_);

+ auto* manager = GuestViewManager::FromBrowserContext(browser_context_);

if (!manager) {

manager = GuestViewManager::CreateWithDelegate(

browser_context_, base::WrapUnique(

@@ -103,7 +103,7 @@ void GuestViewMessageFilter::OnAttachGuest(

int guest_instance_id,

const base::DictionaryValue& params) {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

- auto manager = GuestViewManager::FromBrowserContext(browser_context_);

+ auto* manager = GuestViewManager::FromBrowserContext(browser_context_);

// We should have a GuestViewManager at this point. If we don't then the

// embedder is misbehaving.

if (!manager)