components/bubble/bubble_manager.cc - Issue 2110663002: components: Change auto to not deduce raw pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bubble/bubble_manager.cc

Issue 2110663002: components: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/bookmarks/managed/managed_bookmark_service.cc ('k') | components/component_updater/component_updater_service.cc » ('j') | components/password_manager/core/browser/credential_manager_pending_request_task.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/bubble/bubble_manager.cc

diff --git a/components/bubble/bubble_manager.cc b/components/bubble/bubble_manager.cc

index a4b48351a06c1f1f7770258c2786b44fc092a75a..dc94dc25fb76ab99ef7989b32248c7e8eb6f4221 100644

--- a/components/bubble/bubble_manager.cc

+++ b/components/bubble/bubble_manager.cc

@@ -67,7 +67,7 @@ void BubbleManager::UpdateAllBubbleAnchors() {

// Guard against bubbles being added or removed while iterating the bubbles.

ManagerState original_state = manager_state_;

manager_state_ = ITERATING_BUBBLES;

- for (auto controller : controllers_)

+ for (auto* controller : controllers_)

controller->UpdateAnchorPosition();

manager_state_ = original_state;

}

@@ -122,7 +122,7 @@ bool BubbleManager::CloseAllMatchingBubbles(

}

manager_state_ = original_state;

- for (auto controller : close_queue) {

+ for (auto* controller : close_queue) {

controller->DoClose(reason);

FOR_EACH_OBSERVER(BubbleManagerObserver, observers_,