components/autofill/core/browser/autofill_profile.cc - Issue 2110663002: components: Change auto to not deduce raw pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_profile.cc

Issue 2110663002: components: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_manager.cc ('k') | components/autofill/core/browser/form_structure.cc » ('j') | components/password_manager/core/browser/credential_manager_pending_request_task.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_profile.cc

diff --git a/components/autofill/core/browser/autofill_profile.cc b/components/autofill/core/browser/autofill_profile.cc

index ee5111b1d0ca28fcf736ae562e6f753217683a92..f1d4a4284045f856b078ec72657eaf1614203b3a 100644

--- a/components/autofill/core/browser/autofill_profile.cc

+++ b/components/autofill/core/browser/autofill_profile.cc

@@ -283,7 +283,7 @@ void AutofillProfile::GetMatchingTypes(

const std::string& app_locale,

ServerFieldTypeSet* matching_types) const {

FormGroupList info = FormGroups();

- for (const auto& it : info) {

+ for (auto* it : info) {

it->GetMatchingTypes(text, app_locale, matching_types);

}

@@ -793,7 +793,7 @@ base::string16 AutofillProfile::CanonicalizeProfileString(

void AutofillProfile::GetSupportedTypes(

ServerFieldTypeSet* supported_types) const {

FormGroupList info = FormGroups();

- for (const auto& it : info) {

+ for (auto* it : info) {

it->GetSupportedTypes(supported_types);

}