MediaCaptureFromElement: add captureStreamUntilEnded() and LayoutTest

MediaCaptureFromElement: add captureStreamUntilEnded() and LayoutTest

This CL adds captureStreamUntilEnded() method to 
HTMLMediaElement.

When calling such method, a new inner class
HTMLMediaElementOnEndedEventListener is created listening 
to said MediaElement onended event. When that event kicks 
in, the capture MediaStream is streamEnded().

Also, added a LayoutTest for it, and renamed the original 
HTMLMediaElementCapture-capture.html to -captureStream.html


BUG=575495

[mcasas, 2016-06-28 21:42:19]

Patchset #1 (id:1) has been deleted

[mcasas, 2016-06-28 21:45:39]

Description was changed from

==========
MediaCaptureFromElement: add captureStreamUntilEnded() and LayoutTest

This CL allows for binding the "ended" event of the HTMLMediaElement
to the |onended| event listener of the Track(s) of the Stream created
by captureStreamUntilEnded().

BUG=575495
==========

to

==========
MediaCaptureFromElement: add captureStreamUntilEnded() and LayoutTest

This CL adds captureStreamUntilEnded() method to 
HTMLMediaElement.

When calling such method, a new inner class
HTMLMediaElementOnEndedEventListener is created
listening to the said MediaElement onended event.
When that kicks in, the capture MediaStream is
streamEnded().


Added a LayoutTest, and renamed the original 
HTMLMediaElementCapture-capture.html to 
-captureStream.html


BUG=575495
==========

[mcasas, 2016-06-28 21:47:04]

Patchset #1 (id:20001) has been deleted

[mcasas, 2016-06-28 22:29:59]

Description was changed from

==========
MediaCaptureFromElement: add captureStreamUntilEnded() and LayoutTest

This CL adds captureStreamUntilEnded() method to 
HTMLMediaElement.

When calling such method, a new inner class
HTMLMediaElementOnEndedEventListener is created
listening to the said MediaElement onended event.
When that kicks in, the capture MediaStream is
streamEnded().


Added a LayoutTest, and renamed the original 
HTMLMediaElementCapture-capture.html to 
-captureStream.html


BUG=575495
==========

to

==========
MediaCaptureFromElement: add captureStreamUntilEnded() and LayoutTest

This CL adds captureStreamUntilEnded() method to 
HTMLMediaElement.

When calling such method, a new inner class
HTMLMediaElementOnEndedEventListener is created listening 
to said MediaElement onended event. When that event kicks 
in, the capture MediaStream is streamEnded().

Also, added a LayoutTest for it, and renamed the original 
HTMLMediaElementCapture-capture.html to -captureStream.html


BUG=575495
==========

[mcasas, 2016-06-28 23:16:13]

mcasas@chromium.org changed reviewers:
+ foolip@chromium.org

[mcasas, 2016-06-28 23:16:14]

foolip@ easy review, PTAL

[haraken, 2016-06-29 00:46:58]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-06-29 00:46:59]

https://codereview.chromium.org/2110573002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/mediacapturefromelement/HTMLMediaElementCapture.cpp
(right):

https://codereview.chromium.org/2110573002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediacapturefromelement/HTMLMediaElementCapture.cpp:27:
class HTMLMediaElementOnEndedEventListener : public EventListener {

It looks strange that you have to subclass the EventListener class.

Can we instead override EventTarget::dispatchEventInternal and call
m_stream->streamEnded()?

[foolip, 2016-06-29 10:31:04]

https://codereview.chromium.org/2110573002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/mediacapturefromelement/HTMLMediaElementCapture.cpp
(right):

https://codereview.chromium.org/2110573002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediacapturefromelement/HTMLMediaElementCapture.cpp:27:
class HTMLMediaElementOnEndedEventListener : public EventListener {
On 2016/06/29 00:46:59, haraken wrote:
> 
> It looks strange that you have to subclass the EventListener class.
> 
> Can we instead override EventTarget::dispatchEventInternal and call
> m_stream->streamEnded()?

If this is all that this API does, do we really need it on the web platform?
Can't the web app itself simply listen for the event, call stop() on all
MediaStreamTracks and then stop using the MediaStream, letting it be GC'd?

https://codereview.chromium.org/2110573002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediacapturefromelement/HTMLMediaElementCapture.cpp:43:
m_stream->streamEnded();
I think that creating an ended event with scripts and dispatching it would reach
this code path?

It also looks like this doesn't cover the "After playback has ended, changes to
the media element — such as seeking, restarting playback or changing the source
media — do not result in changes to the captured MediaStream." bit in the spec,
because it's possible for streamEnded() to be called internally for a
MediaStream from captureStream() if all the tracks end, and then they'd look
identical? There's no extra state to say that one should get new tracks and the
other not, right?

[mcasas, 2016-06-30 23:58:12]

On 2016/06/29 10:31:04, Philip Jägenstedt wrote:
>
https://codereview.chromium.org/2110573002/diff/40001/third_party/WebKit/Sour...
> File
>
third_party/WebKit/Source/modules/mediacapturefromelement/HTMLMediaElementCapture.cpp
> (right):
> 
>
https://codereview.chromium.org/2110573002/diff/40001/third_party/WebKit/Sour...
>
third_party/WebKit/Source/modules/mediacapturefromelement/HTMLMediaElementCapture.cpp:27:
> class HTMLMediaElementOnEndedEventListener : public EventListener {
> On 2016/06/29 00:46:59, haraken wrote:
> > 
> > It looks strange that you have to subclass the EventListener class.
> > 
> > Can we instead override EventTarget::dispatchEventInternal and call
> > m_stream->streamEnded()?
> 
> If this is all that this API does, do we really need it on the web platform?
> Can't the web app itself simply listen for the event, call stop() on all
> MediaStreamTracks and then stop using the MediaStream, letting it be GC'd?
> 
>
https://codereview.chromium.org/2110573002/diff/40001/third_party/WebKit/Sour...
>
third_party/WebKit/Source/modules/mediacapturefromelement/HTMLMediaElementCapture.cpp:43:
> m_stream->streamEnded();
> I think that creating an ended event with scripts and dispatching it would
reach
> this code path?
> 
> It also looks like this doesn't cover the "After playback has ended, changes
to
> the media element — such as seeking, restarting playback or changing the
source
> media — do not result in changes to the captured MediaStream." bit in the
spec,
> because it's possible for streamEnded() to be called internally for a
> MediaStream from captureStream() if all the tracks end, and then they'd look
> identical? There's no extra state to say that one should get new tracks and
the
> other not, right?




Guys, let's hold on the review until there's clarity as
of the extent of captureStreamUntilEnded() and the spec, SG?

[mcasas, 2016-07-14 18:15:08]

On 2016/06/30 23:58:12, mcasas wrote:
> On 2016/06/29 10:31:04, Philip Jägenstedt wrote:
> >
>
https://codereview.chromium.org/2110573002/diff/40001/third_party/WebKit/Sour...
> > File
> >
>
third_party/WebKit/Source/modules/mediacapturefromelement/HTMLMediaElementCapture.cpp
> > (right):
> > 
> >
>
https://codereview.chromium.org/2110573002/diff/40001/third_party/WebKit/Sour...
> >
>
third_party/WebKit/Source/modules/mediacapturefromelement/HTMLMediaElementCapture.cpp:27:
> > class HTMLMediaElementOnEndedEventListener : public EventListener {
> > On 2016/06/29 00:46:59, haraken wrote:
> > > 
> > > It looks strange that you have to subclass the EventListener class.
> > > 
> > > Can we instead override EventTarget::dispatchEventInternal and call
> > > m_stream->streamEnded()?
> > 
> > If this is all that this API does, do we really need it on the web platform?
> > Can't the web app itself simply listen for the event, call stop() on all
> > MediaStreamTracks and then stop using the MediaStream, letting it be GC'd?
> > 
> >
>
https://codereview.chromium.org/2110573002/diff/40001/third_party/WebKit/Sour...
> >
>
third_party/WebKit/Source/modules/mediacapturefromelement/HTMLMediaElementCapture.cpp:43:
> > m_stream->streamEnded();
> > I think that creating an ended event with scripts and dispatching it would
> reach
> > this code path?
> > 
> > It also looks like this doesn't cover the "After playback has ended, changes
> to
> > the media element — such as seeking, restarting playback or changing the
> source
> > media — do not result in changes to the captured MediaStream." bit in the
> spec,
> > because it's possible for streamEnded() to be called internally for a
> > MediaStream from captureStream() if all the tracks end, and then they'd look
> > identical? There's no extra state to say that one should get new tracks and
> the
> > other not, right?
> 
> 
> 
> 
> Guys, let's hold on the review until there's clarity as
> of the extent of captureStreamUntilEnded() and the spec, SG?

Finally I got some time to file
https://github.com/w3c/mediacapture-fromelement/issues/42.

[mcasas, 2016-08-04 01:27:37]

On 2016/07/14 18:15:08, mcasas wrote:
> On 2016/06/30 23:58:12, mcasas wrote:
> > On 2016/06/29 10:31:04, Philip Jägenstedt wrote:
> > >
> >
>
https://codereview.chromium.org/2110573002/diff/40001/third_party/WebKit/Sour...
> > > File
> > >
> >
>
third_party/WebKit/Source/modules/mediacapturefromelement/HTMLMediaElementCapture.cpp
> > > (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2110573002/diff/40001/third_party/WebKit/Sour...
> > >
> >
>
third_party/WebKit/Source/modules/mediacapturefromelement/HTMLMediaElementCapture.cpp:27:
> > > class HTMLMediaElementOnEndedEventListener : public EventListener {
> > > On 2016/06/29 00:46:59, haraken wrote:
> > > > 
> > > > It looks strange that you have to subclass the EventListener class.
> > > > 
> > > > Can we instead override EventTarget::dispatchEventInternal and call
> > > > m_stream->streamEnded()?
> > > 
> > > If this is all that this API does, do we really need it on the web
platform?
> > > Can't the web app itself simply listen for the event, call stop() on all
> > > MediaStreamTracks and then stop using the MediaStream, letting it be GC'd?
> > > 
> > >
> >
>
https://codereview.chromium.org/2110573002/diff/40001/third_party/WebKit/Sour...
> > >
> >
>
third_party/WebKit/Source/modules/mediacapturefromelement/HTMLMediaElementCapture.cpp:43:
> > > m_stream->streamEnded();
> > > I think that creating an ended event with scripts and dispatching it would
> > reach
> > > this code path?
> > > 
> > > It also looks like this doesn't cover the "After playback has ended,
changes
> > to
> > > the media element — such as seeking, restarting playback or changing the
> > source
> > > media — do not result in changes to the captured MediaStream." bit in the
> > spec,
> > > because it's possible for streamEnded() to be called internally for a
> > > MediaStream from captureStream() if all the tracks end, and then they'd
look
> > > identical? There's no extra state to say that one should get new tracks
and
> > the
> > > other not, right?
> > 
> > 
> > 
> > 
> > Guys, let's hold on the review until there's clarity as
> > of the extent of captureStreamUntilEnded() and the spec, SG?
> 
> Finally I got some time to file
> https://github.com/w3c/mediacapture-fromelement/issues/42.

https://github.com/w3c/mediacapture-fromelement/pull/45 finally removed
the method in the CL description, so I'm closing this issue, thanks !!

[foolip, 2016-08-04 08:34:04]

Yay, thanks for helping out!