third_party/WebKit/Source/core/page/Page.h - Issue 2110543008: Move UndoStack from Page to Editor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/Page.h

Issue 2110543008: Move UndoStack from Page to Editor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use |const Member| and add notes to UndoStack class Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/Page.h

diff --git a/third_party/WebKit/Source/core/page/Page.h b/third_party/WebKit/Source/core/page/Page.h

index b56d35aa02a9b090247719f2c2a1777ceb2fc547..c22f2b0c1d501f9d371a2141cd52ad7041e6c97c 100644

--- a/third_party/WebKit/Source/core/page/Page.h

+++ b/third_party/WebKit/Source/core/page/Page.h

@@ -62,7 +62,6 @@ class PointerLockController;

class ScrollingCoordinator;

class Settings;

class SpellCheckerClient;

-class UndoStack;

class ValidationMessageClient;

class WebLayerTreeView;

@@ -124,7 +123,6 @@ public:

EditorClient& editorClient() const { return *m_editorClient; }

SpellCheckerClient& spellCheckerClient() const { return *m_spellCheckerClient; }

- UndoStack& undoStack() const { return *m_undoStack; }

void setMainFrame(Frame*);

Frame* mainFrame() const { return m_mainFrame; }

@@ -226,7 +224,6 @@ private:

const Member<ContextMenuController> m_contextMenuController;

const Member<PointerLockController> m_pointerLockController;

Member<ScrollingCoordinator> m_scrollingCoordinator;

- const Member<UndoStack> m_undoStack;

// Typically, the main frame and Page should both be owned by the embedder,

// which must call Page::willBeDestroyed() prior to destroying Page. This