Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: third_party/WebKit/Source/core/page/Page.h

Issue 2110543008: Move UndoStack from Page to Editor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use |const Member| and add notes to UndoStack class Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserv ed. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserv ed.
3 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 3 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 class DragController; 55 class DragController;
56 class EditorClient; 56 class EditorClient;
57 class FocusController; 57 class FocusController;
58 class Frame; 58 class Frame;
59 class FrameHost; 59 class FrameHost;
60 class PluginData; 60 class PluginData;
61 class PointerLockController; 61 class PointerLockController;
62 class ScrollingCoordinator; 62 class ScrollingCoordinator;
63 class Settings; 63 class Settings;
64 class SpellCheckerClient; 64 class SpellCheckerClient;
65 class UndoStack;
66 class ValidationMessageClient; 65 class ValidationMessageClient;
67 class WebLayerTreeView; 66 class WebLayerTreeView;
68 67
69 typedef uint64_t LinkHash; 68 typedef uint64_t LinkHash;
70 69
71 float deviceScaleFactor(LocalFrame*); 70 float deviceScaleFactor(LocalFrame*);
72 71
73 class CORE_EXPORT Page final : public GarbageCollectedFinalized<Page>, public Su pplementable<Page>, public PageLifecycleNotifier, public SettingsDelegate { 72 class CORE_EXPORT Page final : public GarbageCollectedFinalized<Page>, public Su pplementable<Page>, public PageLifecycleNotifier, public SettingsDelegate {
74 USING_GARBAGE_COLLECTED_MIXIN(Page); 73 USING_GARBAGE_COLLECTED_MIXIN(Page);
75 WTF_MAKE_NONCOPYABLE(Page); 74 WTF_MAKE_NONCOPYABLE(Page);
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 void setNeedsRecalcStyleInAllFrames(); 116 void setNeedsRecalcStyleInAllFrames();
118 void updateAcceleratedCompositingSettings(); 117 void updateAcceleratedCompositingSettings();
119 118
120 ViewportDescription viewportDescription() const; 119 ViewportDescription viewportDescription() const;
121 120
122 static void refreshPlugins(); 121 static void refreshPlugins();
123 PluginData* pluginData() const; 122 PluginData* pluginData() const;
124 123
125 EditorClient& editorClient() const { return *m_editorClient; } 124 EditorClient& editorClient() const { return *m_editorClient; }
126 SpellCheckerClient& spellCheckerClient() const { return *m_spellCheckerClien t; } 125 SpellCheckerClient& spellCheckerClient() const { return *m_spellCheckerClien t; }
127 UndoStack& undoStack() const { return *m_undoStack; }
128 126
129 void setMainFrame(Frame*); 127 void setMainFrame(Frame*);
130 Frame* mainFrame() const { return m_mainFrame; } 128 Frame* mainFrame() const { return m_mainFrame; }
131 // Escape hatch for existing code that assumes that the root frame is 129 // Escape hatch for existing code that assumes that the root frame is
132 // always a LocalFrame. With OOPI, this is not always the case. Code that 130 // always a LocalFrame. With OOPI, this is not always the case. Code that
133 // depends on this will generally have to be rewritten to propagate any 131 // depends on this will generally have to be rewritten to propagate any
134 // necessary state through all renderer processes for that page and/or 132 // necessary state through all renderer processes for that page and/or
135 // coordinate/rely on the browser process to help dispatch/coordinate work. 133 // coordinate/rely on the browser process to help dispatch/coordinate work.
136 LocalFrame* deprecatedLocalMainFrame() const { return toLocalFrame(m_mainFra me); } 134 LocalFrame* deprecatedLocalMainFrame() const { return toLocalFrame(m_mainFra me); }
137 135
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
219 217
220 Member<PageAnimator> m_animator; 218 Member<PageAnimator> m_animator;
221 const Member<AutoscrollController> m_autoscrollController; 219 const Member<AutoscrollController> m_autoscrollController;
222 Member<ChromeClient> m_chromeClient; 220 Member<ChromeClient> m_chromeClient;
223 const Member<DragCaretController> m_dragCaretController; 221 const Member<DragCaretController> m_dragCaretController;
224 const Member<DragController> m_dragController; 222 const Member<DragController> m_dragController;
225 const Member<FocusController> m_focusController; 223 const Member<FocusController> m_focusController;
226 const Member<ContextMenuController> m_contextMenuController; 224 const Member<ContextMenuController> m_contextMenuController;
227 const Member<PointerLockController> m_pointerLockController; 225 const Member<PointerLockController> m_pointerLockController;
228 Member<ScrollingCoordinator> m_scrollingCoordinator; 226 Member<ScrollingCoordinator> m_scrollingCoordinator;
229 const Member<UndoStack> m_undoStack;
230 227
231 // Typically, the main frame and Page should both be owned by the embedder, 228 // Typically, the main frame and Page should both be owned by the embedder,
232 // which must call Page::willBeDestroyed() prior to destroying Page. This 229 // which must call Page::willBeDestroyed() prior to destroying Page. This
233 // call detaches the main frame and clears this pointer, thus ensuring that 230 // call detaches the main frame and clears this pointer, thus ensuring that
234 // this field only references a live main frame. 231 // this field only references a live main frame.
235 // 232 //
236 // However, there are several locations (InspectorOverlay, SVGImage, and 233 // However, there are several locations (InspectorOverlay, SVGImage, and
237 // WebPagePopupImpl) which don't hold a reference to the main frame at all 234 // WebPagePopupImpl) which don't hold a reference to the main frame at all
238 // after creating it. These are still safe because they always create a 235 // after creating it. These are still safe because they always create a
239 // Frame with a FrameView. FrameView and Frame hold references to each 236 // Frame with a FrameView. FrameView and Frame hold references to each
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
272 Member<FrameHost> m_frameHost; 269 Member<FrameHost> m_frameHost;
273 270
274 Timer<Page> m_timerForCompressStrings; 271 Timer<Page> m_timerForCompressStrings;
275 }; 272 };
276 273
277 extern template class CORE_EXTERN_TEMPLATE_EXPORT Supplement<Page>; 274 extern template class CORE_EXTERN_TEMPLATE_EXPORT Supplement<Page>;
278 275
279 } // namespace blink 276 } // namespace blink
280 277
281 #endif // Page_h 278 #endif // Page_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/loader/FrameLoader.cpp ('k') | third_party/WebKit/Source/core/page/Page.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698