components/url_formatter/BUILD.gn - Issue 2110543004: Move JNI bindings for url_formatter from chrome to //components/url_formatter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/url_formatter/BUILD.gn

Issue 2110543004: Move JNI bindings for url_formatter from chrome to //components/url_formatter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: gyp: conditionally exclude Android sources Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/url_formatter/BUILD.gn

diff --git a/components/url_formatter/BUILD.gn b/components/url_formatter/BUILD.gn

index 0bd6e01e818125dc6e0cdebcf2e0e1088a0f0b71..8d363c07a5925dd99150bb5fe8b1a3e8bad9122c 100644

--- a/components/url_formatter/BUILD.gn

+++ b/components/url_formatter/BUILD.gn

@@ -10,6 +10,8 @@ source_set("url_formatter") {

"url_fixer.h",

"url_formatter.cc",

"url_formatter.h",

+ "url_formatter_android.cc",

+ "url_formatter_android.h",

]

# TODO(jschuh): crbug.com/167187 fix size_t to int truncations.

@@ -24,6 +26,8 @@ source_set("url_formatter") {

if (!is_android) {

Peter Kasting 2016/07/01 06:59:33 Nit: Reverse condition and arms

deps += [ "//ui/gfx" ]

+ } else {

+ deps += [ "android:jni_headers" ]

}

« no previous file with comments | « chrome/chrome.gyp ('k') | components/url_formatter/DEPS » ('j') | components/url_formatter/android/BUILD.gn » ('J')