Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Side by Side Diff: components/url_formatter/BUILD.gn

Issue 2110543004: Move JNI bindings for url_formatter from chrome to //components/url_formatter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: gyp: conditionally exclude Android sources Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 source_set("url_formatter") { 5 source_set("url_formatter") {
6 sources = [ 6 sources = [
7 "elide_url.cc", 7 "elide_url.cc",
8 "elide_url.h", 8 "elide_url.h",
9 "url_fixer.cc", 9 "url_fixer.cc",
10 "url_fixer.h", 10 "url_fixer.h",
11 "url_formatter.cc", 11 "url_formatter.cc",
12 "url_formatter.h", 12 "url_formatter.h",
13 "url_formatter_android.cc",
14 "url_formatter_android.h",
13 ] 15 ]
14 16
15 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. 17 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
16 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] 18 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
17 19
18 deps = [ 20 deps = [
19 "//base", 21 "//base",
20 "//net", 22 "//net",
21 "//third_party/icu", 23 "//third_party/icu",
22 "//url", 24 "//url",
23 ] 25 ]
24 26
25 if (!is_android) { 27 if (!is_android) {
Peter Kasting 2016/07/01 06:59:33 Nit: Reverse condition and arms
26 deps += [ "//ui/gfx" ] 28 deps += [ "//ui/gfx" ]
29 } else {
30 deps += [ "android:jni_headers" ]
27 } 31 }
28 } 32 }
29 33
30 source_set("unit_tests") { 34 source_set("unit_tests") {
31 testonly = true 35 testonly = true
32 sources = [ 36 sources = [
33 "elide_url_unittest.cc", 37 "elide_url_unittest.cc",
34 "url_fixer_unittest.cc", 38 "url_fixer_unittest.cc",
35 "url_formatter_unittest.cc", 39 "url_formatter_unittest.cc",
36 ] 40 ]
37 41
38 deps = [ 42 deps = [
39 ":url_formatter", 43 ":url_formatter",
40 "//base", 44 "//base",
41 "//net", 45 "//net",
42 "//testing/gtest", 46 "//testing/gtest",
43 "//ui/gfx", 47 "//ui/gfx",
44 "//url", 48 "//url",
45 ] 49 ]
46 50
47 if (is_android) { 51 if (is_android) {
48 deps -= [ "//ui/gfx" ] 52 deps -= [ "//ui/gfx" ]
49 } 53 }
50 } 54 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698