Remove pending demuxer read state, prefer flag, it's not stable.

Remove pending demuxer read state, prefer flag, it's not stable.

The pending demuxer read state is overwritten in too many cases to
be reliable, instead always use the flag instead of trying to have
it both ways.

The main issue this fixes is where there are parallel decodes and a
demuxer read outstanding, one decode completes with an error, and
the new decoder is initialized before the demuxer read completes.

Previously this would stomp the pending read state and we'd try to
issue a new demuxer read when the decoder initialization completed,
blowing up the demuxer in the process.

BUG=597605
TEST=new unittest

Committed: https://crrev.com/5d162a60859414d5ab14fd2a1b234cc1dd6afda7
Cr-Commit-Position: refs/heads/master@{#402667}

[DaleCurtis, 2016-06-28 23:10:58]

dalecurtis@chromium.org changed reviewers:
+ sandersd@chromium.org, tguilbert@chromium.org

[DaleCurtis, 2016-06-28 23:12:06]

dalecurtis@chromium.org changed reviewers:
+ watk@chromium.org
- sandersd@chromium.org

[tguilbert, 2016-06-28 23:33:29]

Looks good % one nit. I am not officially allowed to concat LG and TM yet though
:)

https://codereview.chromium.org/2110463003/diff/1/media/filters/video_frame_s...
File media/filters/video_frame_stream_unittest.cc (right):

https://codereview.chromium.org/2110463003/diff/1/media/filters/video_frame_s...
media/filters/video_frame_stream_unittest.cc:838:
ASSERT_EQ(decoder2_->total_bytes_decoded(), 0);
Could EXPECT_EQ be used here instead?

[watk, 2016-06-28 23:55:57]

lgtm

[DaleCurtis, 2016-06-29 00:03:27]

tguilbert@ practice makes perfect, so feel free to stamp :)

https://codereview.chromium.org/2110463003/diff/1/media/filters/video_frame_s...
File media/filters/video_frame_stream_unittest.cc (right):

https://codereview.chromium.org/2110463003/diff/1/media/filters/video_frame_s...
media/filters/video_frame_stream_unittest.cc:838:
ASSERT_EQ(decoder2_->total_bytes_decoded(), 0);
On 2016/06/28 at 23:33:29, ThomasGuilbert wrote:
> Could EXPECT_EQ be used here instead?

Done!

[DaleCurtis, 2016-06-29 00:03:56]

The CQ bit was checked by dalecurtis@chromium.org

[DaleCurtis, 2016-06-29 00:03:57]

The patchset sent to the CQ was uploaded after l-g-t-m from watk@chromium.org
Link to the patchset: https://codereview.chromium.org/2110463003/#ps20001
(title: "Use expect.")

[commit-bot: I haz the power, 2016-06-29 00:05:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 02:21:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-29 02:24:03]

Description was changed from

==========
Remove pending demuxer read state, prefer flag, it's not stable.

The pending demuxer read state is overwritten in too many cases to
be reliable, instead always use the flag instead of trying to have
it both ways.

The main issue this fixes is where there are parallel decodes and a
demuxer read outstanding, one decode completes with an error, and
the new decoder is initialized before the demuxer read completes.

Previously this would stomp the pending read state and we'd try to
issue a new demuxer read when the decoder initialization completed,
blowing up the demuxer in the process.

BUG=597605
TEST=new unittest
==========

to

==========
Remove pending demuxer read state, prefer flag, it's not stable.

The pending demuxer read state is overwritten in too many cases to
be reliable, instead always use the flag instead of trying to have
it both ways.

The main issue this fixes is where there are parallel decodes and a
demuxer read outstanding, one decode completes with an error, and
the new decoder is initialized before the demuxer read completes.

Previously this would stomp the pending read state and we'd try to
issue a new demuxer read when the decoder initialization completed,
blowing up the demuxer in the process.

BUG=597605
TEST=new unittest

Committed: https://crrev.com/5d162a60859414d5ab14fd2a1b234cc1dd6afda7
Cr-Commit-Position: refs/heads/master@{#402667}
==========

[commit-bot: I haz the power, 2016-06-29 02:24:04]

Patchset 2 (id:??) landed as
https://crrev.com/5d162a60859414d5ab14fd2a1b234cc1dd6afda7
Cr-Commit-Position: refs/heads/master@{#402667}