media/filters/decoder_stream.h - Issue 2110463003: Remove pending demuxer read state, prefer flag, it's not stable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/decoder_stream.h

Issue 2110463003: Remove pending demuxer read state, prefer flag, it's not stable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use expect. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/filters/decoder_stream.h

diff --git a/media/filters/decoder_stream.h b/media/filters/decoder_stream.h

index 8a08193a9a7290fac5a7fc58b9232a00acfa11ea..5480373f2a6322c1a53a26b73e1600da1f369ed0 100644

--- a/media/filters/decoder_stream.h

+++ b/media/filters/decoder_stream.h

@@ -141,7 +141,6 @@ class MEDIA_EXPORT DecoderStream {

STATE_INITIALIZING,

STATE_NORMAL, // Includes idle, pending decoder decode/reset.

STATE_FLUSHING_DECODER,

- STATE_PENDING_DEMUXER_READ,

STATE_REINITIALIZING_DECODER,

STATE_END_OF_STREAM, // End of stream reached; returns EOS on all reads.

STATE_ERROR,

@@ -257,8 +256,8 @@ class MEDIA_EXPORT DecoderStream {

// crbug.com/603713

bool received_config_change_during_reinit_;

- // Used to track read requests in case the STATE_PENDIND_DEMUXER_READ get

- // overwritten by an error.

+ // Used to track read requests; not rolled into |state_| since that is

+ // overwritten in many cases.

bool pending_demuxer_read_;

// NOTE: Weak pointers must be invalidated before all other member variables.

« no previous file with comments | « no previous file | media/filters/decoder_stream.cc » ('j') | no next file with comments »