Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Issue 2110393004: Parse snippet times properly. (Closed)

Created:
4 years, 5 months ago by sfiera
Modified:
4 years, 5 months ago
Reviewers:
Marc Treib
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Parse snippet times as ISO 8601 times. Apparently this is what the server sends back. It's a nicer format than the timestamp struct, but a bit unexpected. BUG=621090 Committed: https://crrev.com/9bb41193745d30267faa815a5538267d253fd028 Cr-Commit-Position: refs/heads/master@{#403212}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -27 lines) Patch
M components/ntp_snippets/ntp_snippet.cc View 1 chunk +3 lines, -10 lines 0 comments Download
M components/ntp_snippets/ntp_snippet_unittest.cc View 1 2 chunks +3 lines, -9 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_fetcher_unittest.cc View 1 chunk +2 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
sfiera
Still running tests to see if Time::FromString() will parse ISO 8601 dates. Really would be ...
4 years, 5 months ago (2016-06-30 16:07:55 UTC) #2
Marc Treib
lgtm
4 years, 5 months ago (2016-06-30 16:44:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110393004/20001
4 years, 5 months ago (2016-06-30 16:56:53 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-30 17:43:25 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 17:45:29 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9bb41193745d30267faa815a5538267d253fd028
Cr-Commit-Position: refs/heads/master@{#403212}

Powered by Google App Engine
This is Rietveld 408576698