components/ntp_snippets/ntp_snippets_fetcher_unittest.cc - Issue 2110393004: Parse snippet times properly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/ntp_snippets_fetcher_unittest.cc

Issue 2110393004: Parse snippet times properly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/ntp_snippets/ntp_snippets_fetcher_unittest.cc

diff --git a/components/ntp_snippets/ntp_snippets_fetcher_unittest.cc b/components/ntp_snippets/ntp_snippets_fetcher_unittest.cc

index 1fbeacd84d510920b83ac27ca975bbd47b4ebfeb..a0f7893ac6e11f2f6b2eccf3c5a587b2d7a6580e 100644

--- a/components/ntp_snippets/ntp_snippets_fetcher_unittest.cc

+++ b/components/ntp_snippets/ntp_snippets_fetcher_unittest.cc

@@ -383,14 +383,8 @@ TEST_F(NTPSnippetsContentSuggestionsFetcherTest, ShouldFetchSuccessfully) {

" \"title\" : \"Foo Barred from Baz\","

" \"summaryText\" : \"...\","

" \"fullPageUrl\" : \"http://localhost/foobar\","

- " \"publishTime\" : {"

- " \"seconds\": 1466510682,"

- " \"nanos\": 552743000 "

- " },"

- " \"expirationTime\" : {"

- " \"seconds\" : 1466597082,"

- " \"nanos\" : 552743000 "

- " },"

+ " \"publishTime\" : \"2016-06-30T11:01:37.000Z\","

+ " \"expirationTime\" : \"2016-07-01T11:01:37.000Z\","

" \"publisherName\" : \"Foo News\","

" \"imageUrl\" : \"http://localhost/foobar.jpg\","

" \"ampUrl\" : \"http://localhost/amp\","

« no previous file with comments | « components/ntp_snippets/ntp_snippet_unittest.cc ('k') | no next file » | no next file with comments »