Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2110393003: [Autofill] Create more descriptive form submitted user actions. (Closed)

Created:
4 years, 5 months ago by sebsg
Modified:
4 years, 5 months ago
Reviewers:
Mathieu, rkaplow
CC:
chromium-reviews, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, asvitkine+watch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added the following user actions: Autofill_FormSubmitted_NonFillable Autofill_FormSubmitted_FilledAll Autofill_FormSubmitted_FilledSome Autofill_FormSubmitted_FilledNone_SuggestionsShown Autofill_FormSubmitted_FilledNone_SuggestionsNotShown BUG=624831 Committed: https://crrev.com/2291f44ecdf5ffefbe28f13289a2d14742c8005d Cr-Commit-Position: refs/heads/master@{#403247}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Marked orignial user action as obselete #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -4 lines) Patch
M components/autofill/core/browser/autofill_metrics.cc View 2 chunks +31 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics_unittest.cc View 8 chunks +25 lines, -2 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
sebsg
Hi Math, could you please take a look? Thanks!
4 years, 5 months ago (2016-06-30 16:54:46 UTC) #3
Mathieu
lgtm for autofill stuff
4 years, 5 months ago (2016-06-30 17:50:04 UTC) #4
sebsg
Hi Robert, could you please take a look at tools/metrics/actions/actions.xml? Thanks!
4 years, 5 months ago (2016-06-30 17:52:06 UTC) #6
rkaplow
lgtm https://codereview.chromium.org/2110393003/diff/1/tools/metrics/actions/actions.xml File tools/metrics/actions/actions.xml (left): https://codereview.chromium.org/2110393003/diff/1/tools/metrics/actions/actions.xml#oldcode1012 tools/metrics/actions/actions.xml:1012: <action name="Autofill_FormSubmitted"> leave this and mark as obsolete
4 years, 5 months ago (2016-06-30 18:30:52 UTC) #7
sebsg
Thanks, will submit. https://codereview.chromium.org/2110393003/diff/1/tools/metrics/actions/actions.xml File tools/metrics/actions/actions.xml (left): https://codereview.chromium.org/2110393003/diff/1/tools/metrics/actions/actions.xml#oldcode1012 tools/metrics/actions/actions.xml:1012: <action name="Autofill_FormSubmitted"> On 2016/06/30 18:30:51, rkaplow ...
4 years, 5 months ago (2016-06-30 18:39:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110393003/20001
4 years, 5 months ago (2016-06-30 18:39:39 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-30 19:24:03 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 19:25:54 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2291f44ecdf5ffefbe28f13289a2d14742c8005d
Cr-Commit-Position: refs/heads/master@{#403247}

Powered by Google App Engine
This is Rietveld 408576698