Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: components/autofill/core/browser/autofill_metrics.cc

Issue 2110393003: [Autofill] Create more descriptive form submitted user actions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Marked orignial user action as obselete Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_metrics_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/browser/autofill_metrics.cc
diff --git a/components/autofill/core/browser/autofill_metrics.cc b/components/autofill/core/browser/autofill_metrics.cc
index be8e8ef8513b0bbbeaedf265f55f1f731155c01e..fe299ddbe7dac884b06cb51179aa087145098413 100644
--- a/components/autofill/core/browser/autofill_metrics.cc
+++ b/components/autofill/core/browser/autofill_metrics.cc
@@ -581,6 +581,37 @@ void AutofillMetrics::LogAutofillFormSubmittedState(
AutofillFormSubmittedState state) {
UMA_HISTOGRAM_ENUMERATION("Autofill.FormSubmittedState", state,
AUTOFILL_FORM_SUBMITTED_STATE_ENUM_SIZE);
+
+ switch (state) {
+ case NON_FILLABLE_FORM_OR_NEW_DATA:
+ base::RecordAction(
+ base::UserMetricsAction("Autofill_FormSubmitted_NonFillable"));
+ break;
+
+ case FILLABLE_FORM_AUTOFILLED_ALL:
+ base::RecordAction(
+ base::UserMetricsAction("Autofill_FormSubmitted_FilledAll"));
+ break;
+
+ case FILLABLE_FORM_AUTOFILLED_SOME:
+ base::RecordAction(
+ base::UserMetricsAction("Autofill_FormSubmitted_FilledSome"));
+ break;
+
+ case FILLABLE_FORM_AUTOFILLED_NONE_DID_SHOW_SUGGESTIONS:
+ base::RecordAction(base::UserMetricsAction(
+ "Autofill_FormSubmitted_FilledNone_SuggestionsShown"));
+ break;
+
+ case FILLABLE_FORM_AUTOFILLED_NONE_DID_NOT_SHOW_SUGGESTIONS:
+ base::RecordAction(base::UserMetricsAction(
+ "Autofill_FormSubmitted_FilledNone_SuggestionsNotShown"));
+ break;
+
+ default:
+ NOTREACHED();
+ break;
+ }
}
// static
@@ -763,8 +794,6 @@ void AutofillMetrics::FormEventLogger::OnFormSubmitted() {
} else {
Log(AutofillMetrics::FORM_EVENT_LOCAL_SUGGESTION_SUBMITTED_ONCE);
}
-
- base::RecordAction(base::UserMetricsAction("Autofill_FormSubmitted"));
}
void AutofillMetrics::FormEventLogger::Log(FormEvent event) const {
« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_metrics_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698