Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Unified Diff: src/compiler/js-native-context-specialization.cc

Issue 2110343003: [turbofan] Always silence NaNs when storing to a double array. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/js-native-context-specialization.cc
diff --git a/src/compiler/js-native-context-specialization.cc b/src/compiler/js-native-context-specialization.cc
index 89d16a7d0048135feb81b77304c3ea29bf570357..20f25d0729b6b7e2378b8f06208b05f8eff80499 100644
--- a/src/compiler/js-native-context-specialization.cc
+++ b/src/compiler/js-native-context-specialization.cc
@@ -782,11 +782,9 @@ Reduction JSNativeContextSpecialization::ReduceElementAccess(
} else if (IsFastDoubleElementsKind(elements_kind)) {
this_value = this_effect = graph()->NewNode(
simplified()->CheckNumber(), this_value, this_effect, this_control);
- // Make sure we do not store signalling NaNs into holey double arrays.
- if (elements_kind == FAST_HOLEY_DOUBLE_ELEMENTS) {
- this_value =
- graph()->NewNode(simplified()->NumberSilenceNaN(), this_value);
- }
+ // Make sure we do not store signalling NaNs into double arrays.
+ this_value =
+ graph()->NewNode(simplified()->NumberSilenceNaN(), this_value);
}
this_effect = graph()->NewNode(simplified()->StoreElement(element_access),
this_elements, this_index, this_value,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698