Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: src/compiler/js-native-context-specialization.cc

Issue 2110343003: [turbofan] Always silence NaNs when storing to a double array. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/js-native-context-specialization.h" 5 #include "src/compiler/js-native-context-specialization.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/compilation-dependencies.h" 9 #include "src/compilation-dependencies.h"
10 #include "src/compiler/access-builder.h" 10 #include "src/compiler/access-builder.h"
(...skipping 764 matching lines...) Expand 10 before | Expand all | Expand 10 after
775 } 775 }
776 } else { 776 } else {
777 DCHECK_EQ(AccessMode::kStore, access_mode); 777 DCHECK_EQ(AccessMode::kStore, access_mode);
778 if (IsFastSmiElementsKind(elements_kind)) { 778 if (IsFastSmiElementsKind(elements_kind)) {
779 this_value = this_effect = 779 this_value = this_effect =
780 graph()->NewNode(simplified()->CheckTaggedSigned(), this_value, 780 graph()->NewNode(simplified()->CheckTaggedSigned(), this_value,
781 this_effect, this_control); 781 this_effect, this_control);
782 } else if (IsFastDoubleElementsKind(elements_kind)) { 782 } else if (IsFastDoubleElementsKind(elements_kind)) {
783 this_value = this_effect = graph()->NewNode( 783 this_value = this_effect = graph()->NewNode(
784 simplified()->CheckNumber(), this_value, this_effect, this_control); 784 simplified()->CheckNumber(), this_value, this_effect, this_control);
785 // Make sure we do not store signalling NaNs into holey double arrays. 785 // Make sure we do not store signalling NaNs into double arrays.
786 if (elements_kind == FAST_HOLEY_DOUBLE_ELEMENTS) { 786 this_value =
787 this_value = 787 graph()->NewNode(simplified()->NumberSilenceNaN(), this_value);
788 graph()->NewNode(simplified()->NumberSilenceNaN(), this_value);
789 }
790 } 788 }
791 this_effect = graph()->NewNode(simplified()->StoreElement(element_access), 789 this_effect = graph()->NewNode(simplified()->StoreElement(element_access),
792 this_elements, this_index, this_value, 790 this_elements, this_index, this_value,
793 this_effect, this_control); 791 this_effect, this_control);
794 } 792 }
795 793
796 // Remember the final state for this element access. 794 // Remember the final state for this element access.
797 values.push_back(this_value); 795 values.push_back(this_value);
798 effects.push_back(this_effect); 796 effects.push_back(this_effect);
799 controls.push_back(this_control); 797 controls.push_back(this_control);
(...skipping 274 matching lines...) Expand 10 before | Expand all | Expand 10 after
1074 } 1072 }
1075 1073
1076 1074
1077 SimplifiedOperatorBuilder* JSNativeContextSpecialization::simplified() const { 1075 SimplifiedOperatorBuilder* JSNativeContextSpecialization::simplified() const {
1078 return jsgraph()->simplified(); 1076 return jsgraph()->simplified();
1079 } 1077 }
1080 1078
1081 } // namespace compiler 1079 } // namespace compiler
1082 } // namespace internal 1080 } // namespace internal
1083 } // namespace v8 1081 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698