content/shell/browser/shell_permission_manager.cc - Issue 2110343002: Reintroduce plumbing for user gesture into permission system.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/shell_permission_manager.cc

Issue 2110343002: Reintroduce plumbing for user gesture into permission system. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Formatting Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/permissions/permission_service_impl.cc ('K') | « content/shell/browser/shell_permission_manager.h ('k') | content/test/mock_permission_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/shell_permission_manager.cc

diff --git a/content/shell/browser/shell_permission_manager.cc b/content/shell/browser/shell_permission_manager.cc

index 6283a7b032680d0af7fa0f6beebb16aaf594fea5..fc0bacb0fc8d22e343ab9ee5f149aad955467e4d 100644

--- a/content/shell/browser/shell_permission_manager.cc

+++ b/content/shell/browser/shell_permission_manager.cc

@@ -32,6 +32,7 @@ int ShellPermissionManager::RequestPermission(

PermissionType permission,

RenderFrameHost* render_frame_host,

const GURL& requesting_origin,

+ bool user_gesture,

const base::Callback<void(blink::mojom::PermissionStatus)>& callback) {

callback.Run(IsWhitelistedPermissionType(permission)

? blink::mojom::PermissionStatus::GRANTED

@@ -43,6 +44,7 @@ int ShellPermissionManager::RequestPermissions(

const std::vector<PermissionType>& permissions,

content::RenderFrameHost* render_frame_host,

const GURL& requesting_origin,

+ bool user_gesture,

const base::Callback<

void(const std::vector<blink::mojom::PermissionStatus>&)>& callback) {

std::vector<blink::mojom::PermissionStatus> result(permissions.size());