Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1157)

Unified Diff: content/browser/permissions/permission_service_impl.cc

Issue 2110343002: Reintroduce plumbing for user gesture into permission system. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Formatting Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/permissions/permission_service_impl.cc
diff --git a/content/browser/permissions/permission_service_impl.cc b/content/browser/permissions/permission_service_impl.cc
index 39daa6434744e97e8fde6e6cbefb1aee0ee1ba90..4c4da88693783fb200c988b1cde3561a3c8dc9c3 100644
--- a/content/browser/permissions/permission_service_impl.cc
+++ b/content/browser/permissions/permission_service_impl.cc
@@ -138,6 +138,7 @@ void PermissionServiceImpl::RequestPermission(
PermissionNameToPermissionType(permission),
context_->render_frame_host(),
GURL(origin.get()),
+ user_gesture, // TODO(mlamouri): should be removed (crbug.com/423770)
dominickn 2016/07/01 01:28:28 Remove this TODO?
benwells 2016/07/01 01:56:29 Done.
base::Bind(&PermissionServiceImpl::OnRequestPermissionResponse,
weak_factory_.GetWeakPtr(),
pending_request_id));
@@ -198,6 +199,7 @@ void PermissionServiceImpl::RequestPermissions(
types,
context_->render_frame_host(),
GURL(origin.get()),
+ user_gesture, // TODO(mlamouri): should be removed (crbug.com/423770)
dominickn 2016/07/01 01:28:29 Remove TODO
benwells 2016/07/01 01:56:29 Done.
base::Bind(&PermissionServiceImpl::OnRequestPermissionsResponse,
weak_factory_.GetWeakPtr(),
pending_request_id));

Powered by Google App Engine
This is Rietveld 408576698