Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/push_messaging/push_messaging_message_filter.cc

Issue 2110343002: Reintroduce plumbing for user gesture into permission system. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Formatting Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/browser/permissions/permission_service_impl.cc ('K') | « content/browser/permissions/permission_service_impl.cc ('k') | content/public/browser/permission_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/push_messaging/push_messaging_message_filter.cc
diff --git a/content/browser/push_messaging/push_messaging_message_filter.cc b/content/browser/push_messaging/push_messaging_message_filter.cc
index 31ddbb504e839f9b911b5aa2fe063e6634937216..e2d9cd517ab93f57f1fb4baf68a2e541d68c510a 100644
--- a/content/browser/push_messaging/push_messaging_message_filter.cc
+++ b/content/browser/push_messaging/push_messaging_message_filter.cc
@@ -396,7 +396,7 @@ void PushMessagingMessageFilter::Core::RegisterOnUI(
->GetPermissionManager()
->RequestPermission(
PermissionType::PUSH_MESSAGING, render_frame_host,
- data.requesting_origin,
+ data.requesting_origin, false /* user_gesture */,
base::Bind(&PushMessagingMessageFilter::Core::
DidRequestPermissionInIncognito,
weak_factory_ui_to_ui_.GetWeakPtr(), data));
« content/browser/permissions/permission_service_impl.cc ('K') | « content/browser/permissions/permission_service_impl.cc ('k') | content/public/browser/permission_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698