Chromium Code Reviews
DescriptionImprove performance of HTMLSelectElement::m_listItems update.
This CL introduces a fast path to update m_listItems directly instead of throwing
it away and reconstructing it. The fast path supports:
- Prepend an OPTION to a SELECT element
- Append an OPTION to a SELECT element
- Remove an OPTION child from a SELECT element or an OPTGROUP element.
Removing 20,000 OPTIONs: 2,813ms -> 200ms
BUG=620142, 624220
Committed: https://crrev.com/ef9c38f033c0f5b11defe2210d2d00737c41b76e
Cr-Commit-Position: refs/heads/master@{#403093}
Patch Set 1 #Patch Set 2 : Avoid DCHECK failure in OOBE tests #
Messages
Total messages: 20 (10 generated)
|
||||||||||||||||||||||||||||