Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2110303002: Improve performance of HTMLSelectElement::m_listItems update. (Closed)

Created:
4 years, 5 months ago by tkent
Modified:
4 years, 5 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve performance of HTMLSelectElement::m_listItems update. This CL introduces a fast path to update m_listItems directly instead of throwing it away and reconstructing it. The fast path supports: - Prepend an OPTION to a SELECT element - Append an OPTION to a SELECT element - Remove an OPTION child from a SELECT element or an OPTGROUP element. Removing 20,000 OPTIONs: 2,813ms -> 200ms BUG=620142, 624220 Committed: https://crrev.com/ef9c38f033c0f5b11defe2210d2d00737c41b76e Cr-Commit-Position: refs/heads/master@{#403093}

Patch Set 1 #

Patch Set 2 : Avoid DCHECK failure in OOBE tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -13 lines) Patch
M third_party/WebKit/Source/core/html/HTMLSelectElement.h View 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 1 5 chunks +46 lines, -9 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
tkent
Keishi, would you review this please?
4 years, 5 months ago (2016-06-30 01:31:58 UTC) #2
keishi
LGTM
4 years, 5 months ago (2016-06-30 01:43:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110303002/1
4 years, 5 months ago (2016-06-30 01:48:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/194495)
4 years, 5 months ago (2016-06-30 02:29:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110303002/1
4 years, 5 months ago (2016-06-30 02:30:29 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/194535)
4 years, 5 months ago (2016-06-30 03:34:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110303002/1
4 years, 5 months ago (2016-06-30 03:35:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110303002/20001
4 years, 5 months ago (2016-06-30 04:08:17 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-30 05:27:10 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 05:28:34 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ef9c38f033c0f5b11defe2210d2d00737c41b76e
Cr-Commit-Position: refs/heads/master@{#403093}

Powered by Google App Engine
This is Rietveld 408576698