Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.h

Issue 2110303002: Improve performance of HTMLSelectElement::m_listItems update. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Avoid DCHECK failure in OOBE tests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLSelectElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLSelectElement.h b/third_party/WebKit/Source/core/html/HTMLSelectElement.h
index 90258429e1e9dee603c025ca2c2485126f67a115..712e1f93e294487c2797942eebf58de2e38268b9 100644
--- a/third_party/WebKit/Source/core/html/HTMLSelectElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLSelectElement.h
@@ -90,7 +90,6 @@ public:
void optionElementChildrenChanged(const HTMLOptionElement&);
- void setRecalcListItems();
void invalidateSelectedItems();
using ListItems = HeapVector<Member<HTMLElement>>;
@@ -122,11 +121,11 @@ public:
// For use in the implementation of HTMLOptionElement.
void optionSelectionStateChanged(HTMLOptionElement*, bool optionIsSelected);
void optionInserted(HTMLOptionElement&, bool optionIsSelected);
- void optionRemoved(const HTMLOptionElement&);
+ void optionRemoved(HTMLOptionElement&);
bool anonymousIndexedSetter(unsigned, HTMLOptionElement*, ExceptionState&);
- void optGroupInsertedOrRemoved(const HTMLOptGroupElement&);
- void hrInsertedOrRemoved(const HTMLHRElement&);
+ void optGroupInsertedOrRemoved(HTMLOptGroupElement&);
+ void hrInsertedOrRemoved(HTMLHRElement&);
void updateListOnLayoutObject();
@@ -197,6 +196,8 @@ private:
void dispatchInputAndChangeEventForMenuList();
+ // |subject| is an element which was inserted or removed.
+ void setRecalcListItems(HTMLElement& subject);
void recalcListItems() const;
enum ResetReason {
ResetReasonSelectedOptionRemoved,
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698