Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1034)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 211023002: DevTools: Remove event Console.messageRepeatCountUpdated (Closed)

Created:
6 years, 9 months ago by sergeyv
Modified:
6 years, 9 months ago
Reviewers:
vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

DevTools: Remove event Console.messageRepeatCountUpdated BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169953

Patch Set 1 #

Total comments: 16

Patch Set 2 : Address pfeldman's comments #

Patch Set 3 : Fix inspector-protocol/console/console-timestamp.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -213 lines) Patch
M LayoutTests/inspector-protocol/console/console-timestamp.html View 1 2 2 chunks +2 lines, -19 lines 0 comments Download
M Source/core/inspector/ConsoleMessage.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/inspector/ConsoleMessage.cpp View 6 chunks +0 lines, -45 lines 0 comments Download
M Source/core/inspector/InspectorConsoleAgent.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorConsoleAgent.cpp View 1 3 chunks +4 lines, -19 lines 0 comments Download
M Source/core/inspector/ScriptArguments.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/ScriptArguments.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
M Source/core/inspector/ScriptCallFrame.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/inspector/ScriptCallFrame.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/inspector/ScriptCallStack.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/inspector/ScriptCallStack.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
M Source/devtools/front_end/CPUProfileView.js View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/ConsoleModel.js View 1 11 chunks +25 lines, -48 lines 0 comments Download
M Source/devtools/front_end/ConsoleView.js View 1 6 chunks +13 lines, -13 lines 0 comments Download
M Source/devtools/front_end/ConsoleViewMessage.js View 1 4 chunks +12 lines, -4 lines 0 comments Download
M Source/devtools/front_end/Main.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/NetworkManager.js View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/PresentationConsoleMessageHelper.js View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/ResourceTreeModel.js View 1 2 chunks +2 lines, -3 lines 0 comments Download
M Source/devtools/front_end/ScriptSnippetModel.js View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/SourceFrame.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/Tests.js View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/devtools/protocol.json View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
sergeyv
6 years, 9 months ago (2014-03-25 12:09:38 UTC) #1
pfeldman
lgtm https://codereview.chromium.org/211023002/diff/1/Source/core/inspector/InspectorConsoleAgent.cpp File Source/core/inspector/InspectorConsoleAgent.cpp (right): https://codereview.chromium.org/211023002/diff/1/Source/core/inspector/InspectorConsoleAgent.cpp#newcode308 Source/core/inspector/InspectorConsoleAgent.cpp:308: consoleMessage.get()->addToFrontend(m_frontend, m_injectedScriptManager, true); remove "get()" https://codereview.chromium.org/211023002/diff/1/Source/devtools/front_end/ConsoleModel.js File Source/devtools/front_end/ConsoleModel.js ...
6 years, 9 months ago (2014-03-25 13:09:31 UTC) #2
sergeyv
https://codereview.chromium.org/211023002/diff/1/Source/core/inspector/InspectorConsoleAgent.cpp File Source/core/inspector/InspectorConsoleAgent.cpp (right): https://codereview.chromium.org/211023002/diff/1/Source/core/inspector/InspectorConsoleAgent.cpp#newcode308 Source/core/inspector/InspectorConsoleAgent.cpp:308: consoleMessage.get()->addToFrontend(m_frontend, m_injectedScriptManager, true); On 2014/03/25 13:09:32, pfeldman wrote: > ...
6 years, 9 months ago (2014-03-25 13:42:56 UTC) #3
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 9 months ago (2014-03-25 13:43:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/211023002/70001
6 years, 9 months ago (2014-03-25 13:43:13 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 14:15:49 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-25 14:15:49 UTC) #7
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 9 months ago (2014-03-25 14:48:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/211023002/140001
6 years, 9 months ago (2014-03-25 14:48:53 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 15:45:52 UTC) #10
Message was sent while issue was closed. 
Change committed as 169953

Powered by Google App Engine
This is Rietveld 408576698