Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2030)

Unified Diff: Source/devtools/front_end/ConsoleView.js

Issue 211023002: DevTools: Remove event Console.messageRepeatCountUpdated (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix inspector-protocol/console/console-timestamp.html Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/ConsoleModel.js ('k') | Source/devtools/front_end/ConsoleViewMessage.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/ConsoleView.js
diff --git a/Source/devtools/front_end/ConsoleView.js b/Source/devtools/front_end/ConsoleView.js
index d5ed5d54183ce01d8e3720e2c9a3cfb47325b824..bcfc64da5f850d1779798f1ac18171ec5744eec7 100644
--- a/Source/devtools/front_end/ConsoleView.js
+++ b/Source/devtools/front_end/ConsoleView.js
@@ -103,6 +103,7 @@ WebInspector.ConsoleView = function(hideContextSelector)
this._messageToViewMessage = new Map();
/** @type {!Array.<!WebInspector.ConsoleMessage>} */
this._consoleMessages = [];
+ this._previousMessage = null;
this.prompt = new WebInspector.TextPromptWithHistory(this._completionsForTextPrompt.bind(this));
this.prompt.setSuggestBoxEnabled("generic-suggest");
@@ -143,7 +144,6 @@ WebInspector.ConsoleView.prototype = {
{
target.consoleModel.addEventListener(WebInspector.ConsoleModel.Events.MessageAdded, this._onConsoleMessageAdded.bind(this, target), this);
target.consoleModel.addEventListener(WebInspector.ConsoleModel.Events.ConsoleCleared, this._consoleCleared, this);
- target.consoleModel.addEventListener(WebInspector.ConsoleModel.Events.RepeatCountUpdated, this._repeatCountUpdated, this);
target.consoleModel.addEventListener(WebInspector.ConsoleModel.Events.CommandEvaluated, this._commandEvaluated, this);
target.consoleModel.messages.forEach(this._consoleMessageAdded.bind(this, target));
@@ -416,13 +416,20 @@ WebInspector.ConsoleView.prototype = {
*/
_consoleMessageAdded: function(target, message)
{
- this._consoleMessages.push(message);
- var viewMessage = this._createViewMessage(target, message);
if (this._urlToMessageCount[message.url])
this._urlToMessageCount[message.url]++;
else
this._urlToMessageCount[message.url] = 1;
+ if (this._previousMessage && !message.isGroupMessage() && message.isEqual(this._previousMessage)) {
+ this._messageToViewMessage.get(this._previousMessage).incrementRepeatCount();
+ return;
+ }
+
+ this._consoleMessages.push(message);
+ this._previousMessage = message;
+ var viewMessage = this._createViewMessage(target, message);
+
if (this._filter.shouldBeVisible(viewMessage))
this._showConsoleMessage(viewMessage);
else
@@ -500,6 +507,7 @@ WebInspector.ConsoleView.prototype = {
this._visibleViewMessages = [];
this._searchResults = [];
+ this._previousMessage = null;
this._messageToViewMessage.clear();
this._consoleMessages = [];
@@ -512,15 +520,6 @@ WebInspector.ConsoleView.prototype = {
this._linkifier.reset();
},
- /**
- * @param {!WebInspector.Event} event
- */
- _repeatCountUpdated: function(event)
- {
- var message = /** @type {!WebInspector.ConsoleMessage} */ (event.data);
- this._messageToViewMessage.get(message).updateRepeatCount();
- },
-
_handleContextMenuEvent: function(event)
{
if (event.target.enclosingNodeOrSelfWithNodeName("a"))
@@ -1075,7 +1074,8 @@ WebInspector.ConsoleCommandResult = function(result, wasThrown, originatingComma
{
this.originatingCommand = originatingCommand;
var level = wasThrown ? WebInspector.ConsoleMessage.MessageLevel.Error : WebInspector.ConsoleMessage.MessageLevel.Log;
- var message = new WebInspector.ConsoleMessage(WebInspector.ConsoleMessage.MessageSource.JS, level, "", WebInspector.ConsoleMessage.MessageType.Result, url, lineNumber, columnNumber, undefined, undefined, [result]);
+
+ var message = new WebInspector.ConsoleMessage(WebInspector.ConsoleMessage.MessageSource.JS, level, "", WebInspector.ConsoleMessage.MessageType.Result, url, lineNumber, columnNumber, undefined, [result]);
WebInspector.ConsoleViewMessage.call(this, result.target(), message, linkifier);
}
« no previous file with comments | « Source/devtools/front_end/ConsoleModel.js ('k') | Source/devtools/front_end/ConsoleViewMessage.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698