Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2110213003: Fix clearing of slots on large page uncommit (Closed)

Created:
4 years, 5 months ago by ulan
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix clearing of slots on large page uncommit BUG=chromium:624544 LOG=NO Committed: https://crrev.com/5a8cfaf06df674c98944348441034267cbccaf79 Cr-Commit-Position: refs/heads/master@{#37451}

Patch Set 1 #

Patch Set 2 : fix compile #

Patch Set 3 : fix types #

Patch Set 4 : x #

Patch Set 5 : x #

Patch Set 6 : x #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -26 lines) Patch
M src/heap/remembered-set.h View 1 2 3 4 5 1 chunk +42 lines, -16 lines 0 comments Download
M src/heap/slot-set.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/spaces.cc View 1 chunk +4 lines, -10 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +62 lines, -0 lines 0 comments Download

Messages

Total messages: 31 (16 generated)
ulan
ptal
4 years, 5 months ago (2016-06-30 08:45:31 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110213003/20001
4 years, 5 months ago (2016-06-30 10:38:26 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/18692)
4 years, 5 months ago (2016-06-30 10:45:33 UTC) #6
Hannes Payer (out of office)
lgtm
4 years, 5 months ago (2016-06-30 12:02:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110213003/20001
4 years, 5 months ago (2016-06-30 12:03:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110213003/40001
4 years, 5 months ago (2016-06-30 12:06:46 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/18701)
4 years, 5 months ago (2016-06-30 12:15:14 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110213003/60001
4 years, 5 months ago (2016-06-30 12:42:21 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/4221) v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED, ...
4 years, 5 months ago (2016-06-30 12:45:15 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110213003/80001
4 years, 5 months ago (2016-06-30 13:48:49 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/18717)
4 years, 5 months ago (2016-06-30 13:56:20 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110213003/100001
4 years, 5 months ago (2016-06-30 14:36:02 UTC) #27
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 5 months ago (2016-06-30 15:01:00 UTC) #28
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 15:01:03 UTC) #29
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 15:03:29 UTC) #31
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/5a8cfaf06df674c98944348441034267cbccaf79
Cr-Commit-Position: refs/heads/master@{#37451}

Powered by Google App Engine
This is Rietveld 408576698