Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: src/heap/spaces.cc

Issue 2110213003: Fix clearing of slots on large page uncommit (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: x Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/slot-set.h ('k') | test/cctest/heap/test-heap.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/spaces.cc
diff --git a/src/heap/spaces.cc b/src/heap/spaces.cc
index d88ec83f77f6704be00649d7cc9e62f09bb0be47..86e80e3d73e2c83835f1adde0d9a4e99194c22db 100644
--- a/src/heap/spaces.cc
+++ b/src/heap/spaces.cc
@@ -2951,16 +2951,10 @@ Address LargePage::GetAddressToShrink() {
}
void LargePage::ClearOutOfLiveRangeSlots(Address free_start) {
- if (old_to_new_slots() != nullptr) {
- old_to_new_slots()->RemoveRange(
- static_cast<int>(free_start - address()),
- static_cast<int>(free_start + size() - address()));
- }
- if (old_to_old_slots() != nullptr) {
- old_to_old_slots()->RemoveRange(
- static_cast<int>(free_start - address()),
- static_cast<int>(free_start + size() - address()));
- }
+ RememberedSet<OLD_TO_NEW>::RemoveRange(this, free_start, area_end());
+ RememberedSet<OLD_TO_OLD>::RemoveRange(this, free_start, area_end());
+ RememberedSet<OLD_TO_NEW>::RemoveRangeTyped(this, free_start, area_end());
+ RememberedSet<OLD_TO_OLD>::RemoveRangeTyped(this, free_start, area_end());
}
// -----------------------------------------------------------------------------
« no previous file with comments | « src/heap/slot-set.h ('k') | test/cctest/heap/test-heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698