Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2110213002: Revert of Add format modifier IDs for EGL_EXT_image_dma_buf_import extension (Closed)

Created:
4 years, 5 months ago by Josh Horwich
Modified:
4 years, 5 months ago
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add format modifier IDs for EGL_EXT_image_dma_buf_import extension (patchset #14 id:260001 of https://codereview.chromium.org/2039813002/ ) Reason for revert: crbug.com/624492 With this change we started getting Failed to create GLImage followed by a flurry of GL_INVALID_OPERATION / GL_INVALID_FRAMEBUFFER_OPERATION on veyron_minnie, see bug for details. Original issue's description: > Add format modifier IDs for EGL_EXT_image_dma_buf_import extension > > And use them when creating a eglImageKHR for a EGL_LINUX_DMA_BUF_EXT target. > > BUG=chromium:478339 > TEST=none > > Signed-off-by: Vince Hsu <vince.h@nvidia.com>; > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/29292a32f6f429a790e8663ce09bf67d165f49e9 > Cr-Commit-Position: refs/heads/master@{#402656} TBR=reveman@chromium.org,alexst@chromium.org,dcastagna@chromium.org,dcheng@chromium.org,dnicoara@chromium.org,jam@chromium.org,jln@chromium.org,jschuh@chromium.org,marcheu@google.com,nasko@chromium.org,piman@chromium.org,rickyz@chromium.org,spang@chromium.org,tsepez@chromium.org,vince.h@nvidia.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:478339, chromium:624492 Committed: https://crrev.com/7410e59a1c7990c4cd74978cc26bcf2e500c8296 Cr-Commit-Position: refs/heads/master@{#402900}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -155 lines) Patch
M chrome/gpu/arc_gpu_video_decode_accelerator.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/exo/display.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/exo/display.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M components/exo/display_unittest.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M components/exo/wayland/server.cc View 3 chunks +13 lines, -12 lines 0 comments Download
M gpu/ipc/client/gpu_channel_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/ipc/client/gpu_memory_buffer_impl_ozone_native_pixmap.h View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/ipc/client/gpu_memory_buffer_impl_ozone_native_pixmap.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M media/gpu/video_decode_accelerator_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/khronos/EGL/eglext.h View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/khronos/README.chromium View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/ipc/gfx_param_traits_macros.h View 1 chunk +1 line, -7 lines 0 comments Download
M ui/gfx/native_pixmap_handle_ozone.h View 2 chunks +3 lines, -19 lines 0 comments Download
M ui/gfx/native_pixmap_handle_ozone.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M ui/gl/gl_image_ozone_native_pixmap.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M ui/gl/gl_image_ozone_native_pixmap_drm_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/cast/surface_factory_cast.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/client_native_pixmap_factory_gbm.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/drm_thread.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_thread.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_thread_proxy.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/drm_thread_proxy.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_buffer.h View 4 chunks +6 lines, -6 lines 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_buffer.cc View 8 chunks +31 lines, -35 lines 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_surface_factory.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M ui/ozone/platform/headless/headless_surface_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/public/native_pixmap.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Josh Horwich
Created Revert of Add format modifier IDs for EGL_EXT_image_dma_buf_import extension
4 years, 5 months ago (2016-06-29 19:32:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110213002/1
4 years, 5 months ago (2016-06-29 19:35:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 19:37:20 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 19:38:10 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 19:40:43 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7410e59a1c7990c4cd74978cc26bcf2e500c8296
Cr-Commit-Position: refs/heads/master@{#402900}

Powered by Google App Engine
This is Rietveld 408576698