Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2109973002: Revert of Remove style spans to follow the styles of the block element (Closed)

Created:
4 years, 5 months ago by shans
Modified:
4 years, 5 months ago
Reviewers:
yosin_UTC9, joone
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove style spans to follow the styles of the block element (patchset #2 id:20001 of https://codereview.chromium.org/2102913002/ ) Reason for revert: Assignment within conditional on line 836 of ReplaceSelectionCommand.cpp is breaking Win8 build: https://build.chromium.org/p/chromium.win/builders/Win8%20GYP%20%28dbg%29/builds/133 Original issue's description: > Remove style spans to follow the styles of the block element > > This CL removes style spans to follow the styles of the block > element(li, pre, td, and h1~6) when the text of the pasted > or merged element becomes a part of the block element. > > BUG=226941 > TEST=third_party/WebKit/LayoutTests/editing/deleting/backspace-merge-into-block-element.html > > Committed: https://crrev.com/5220699381aae450f22d1ea3805141deb139f8f3 > Cr-Commit-Position: refs/heads/master@{#402659} TBR=yosin@chromium.org,joone.hur@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=226941 Committed: https://crrev.com/45859e627709ac2a56e939a00f725a0fca27f75f Cr-Commit-Position: refs/heads/master@{#402696}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -67 lines) Patch
D third_party/WebKit/LayoutTests/editing/deleting/backspace-merge-into-block.html View 1 chunk +0 lines, -36 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/deleting/backspace-merge-into-list-item.html View 1 chunk +34 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/deleting/merge-paragraph-from-p-with-style-3-expected.txt View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp View 3 chunks +3 lines, -30 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
shans
Created Revert of Remove style spans to follow the styles of the block element
4 years, 5 months ago (2016-06-29 03:05:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109973002/1
4 years, 5 months ago (2016-06-29 03:06:03 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 03:06:43 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 03:08:48 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/45859e627709ac2a56e939a00f725a0fca27f75f
Cr-Commit-Position: refs/heads/master@{#402696}

Powered by Google App Engine
This is Rietveld 408576698