Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 2109943002: Workaround RecentTabs blank issue on certain Samsung devices. (Closed)

Created:
4 years, 5 months ago by Ted C
Modified:
4 years, 5 months ago
Reviewers:
Ian Wen
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Workaround RecentTabs blank issue on certain Samsung devices. This was mystifyingly introduced by: https://codereview.chromium.org/2014433002 It turns out that previously, this relied on calls to setStatusBarColor based on theme color notifications when nothing changed. This was triggering a root level relayout, which hid this issue. For now, force a root level relayout when attaching the recent tabs page to the window. BUG=623515 Committed: https://crrev.com/fa6b1daac1f779a831b022dd00b05d3529064020 Cr-Commit-Position: refs/heads/master@{#402681}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsPage.java View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ted C
PTAL
4 years, 5 months ago (2016-06-28 23:53:52 UTC) #2
Ian Wen
lgtm lgtm
4 years, 5 months ago (2016-06-29 00:24:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109943002/1
4 years, 5 months ago (2016-06-29 00:25:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 02:35:37 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 02:38:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa6b1daac1f779a831b022dd00b05d3529064020
Cr-Commit-Position: refs/heads/master@{#402681}

Powered by Google App Engine
This is Rietveld 408576698