Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 2014433002: Fix theme colors not updating when navigating back/from the NTP. (Closed)

Created:
4 years, 6 months ago by Ted C
Modified:
4 years, 6 months ago
Reviewers:
Yusuf
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix theme colors not updating when navigating back/from the NTP. This moves to better centralize and isoalte the theme color tracking. Tab will now be in charge of determining when to notify its observers about theme color changes. The previous problem was that TabWebContentsObserver and Tab were notifying observers and it was a mismatch of who was tracking the theme colors (in particular with the addition of native pages). This also removes the additional handling that was being done in WebContents.java/WebContentsImpl.java as that did not match the native behavior. The need for non-transparent colors should be isolated to the chrome component where we are choosing how to apply them. BUG=614006 Committed: https://crrev.com/e754522e92e66cbef3662d433467fa96958511ac Cr-Commit-Position: refs/heads/master@{#396054}

Patch Set 1 #

Patch Set 2 : Add comments in color calculation #

Patch Set 3 : Rebased #

Patch Set 4 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -55 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 1 2 3 8 chunks +53 lines, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java View 6 chunks +3 lines, -38 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java View 2 chunks +2 lines, -6 lines 0 comments Download
M content/public/android/java/src/org/chromium/content_public/browser/WebContents.java View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Ted C
PTAL
4 years, 6 months ago (2016-05-24 23:13:19 UTC) #2
Yusuf
lgtm
4 years, 6 months ago (2016-05-25 00:11:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014433002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014433002/40001
4 years, 6 months ago (2016-05-25 00:18:04 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/76131)
4 years, 6 months ago (2016-05-25 03:20:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014433002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014433002/60001
4 years, 6 months ago (2016-05-25 22:27:43 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-05-26 00:34:35 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-05-26 00:36:08 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e754522e92e66cbef3662d433467fa96958511ac
Cr-Commit-Position: refs/heads/master@{#396054}

Powered by Google App Engine
This is Rietveld 408576698