DescriptionFix theme colors not updating when navigating back/from the NTP.
This moves to better centralize and isoalte the theme color
tracking. Tab will now be in charge of determining when to
notify its observers about theme color changes.
The previous problem was that TabWebContentsObserver and Tab
were notifying observers and it was a mismatch of who was tracking
the theme colors (in particular with the addition of native pages).
This also removes the additional handling that was being done
in WebContents.java/WebContentsImpl.java as that did not match
the native behavior. The need for non-transparent colors should
be isolated to the chrome component where we are choosing how to
apply them.
BUG=614006
Committed: https://crrev.com/e754522e92e66cbef3662d433467fa96958511ac
Cr-Commit-Position: refs/heads/master@{#396054}
Patch Set 1 #Patch Set 2 : Add comments in color calculation #Patch Set 3 : Rebased #Patch Set 4 : Fix tests #
Messages
Total messages: 14 (7 generated)
|