third_party/WebKit/LayoutTests/inspector/network/network-status-non-http.html - Issue 2109813003: [DevTools] No NetworkManager and NetworkLog for v8only mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/network/network-status-non-http.html

Issue 2109813003: [DevTools] No NetworkManager and NetworkLog for v8only mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing code review comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/network/network-choose-preview-view.html ('k') | third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/network/network-status-non-http.html

diff --git a/third_party/WebKit/LayoutTests/inspector/network/network-status-non-http.html b/third_party/WebKit/LayoutTests/inspector/network/network-status-non-http.html

index 84eb6c51c921a99ad8e1c1569fc1ff607450ae2d..0ece6db19e313403b148045a97d7d52b50c641f8 100644

--- a/third_party/WebKit/LayoutTests/inspector/network/network-status-non-http.html

+++ b/third_party/WebKit/LayoutTests/inspector/network/network-status-non-http.html

@@ -16,7 +16,7 @@ function test()

var urls = document.evaluate("//tbody/tr/td[position()=1]/@title", dataGrid, null, XPathResult.ORDERED_NODE_SNAPSHOT_TYPE, null);

var outputStrings = [];

- for (var request of WebInspector.targetManager.mainTarget().networkLog._requests) {

+ for (var request of WebInspector.NetworkLog.fromTarget(WebInspector.targetManager.mainTarget())._requests) {

var line = request.displayName + ":" + request.statusCode + " " + request.statusText

if (request.failed)

line += "(failed)";