third_party/WebKit/LayoutTests/http/tests/inspector/network/network-choose-preview-view.html - Issue 2109813003: [DevTools] No NetworkManager and NetworkLog for v8only mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/network/network-choose-preview-view.html

Issue 2109813003: [DevTools] No NetworkManager and NetworkLog for v8only mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing code review comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js ('k') | third_party/WebKit/LayoutTests/inspector/network/network-status-non-http.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/network/network-choose-preview-view.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-choose-preview-view.html b/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-choose-preview-view.html

index 28ab6ef85d5b32d3ddb9c491b5376346bb18c198..8939041621b6ac9cc4f8d4c2d0e6bcd9eafedb6a 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-choose-preview-view.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-choose-preview-view.html

@@ -8,7 +8,7 @@ function test()

function createNetworkRequest(mimeType, content, statusCode)

{

InspectorTest.addResult("Creating a NetworkRequest with mimeType: " + mimeType);

- var request = new WebInspector.NetworkRequest(WebInspector.mainTarget, 0, 'http://localhost');

+ var request = new WebInspector.NetworkRequest(WebInspector.targetManager.mainTarget(), 0, 'http://localhost');

InspectorTest.addResult("Content: " + content.replace(/\0/g, "**NULL**"));

request.mimeType = mimeType;

request._content = content;

@@ -85,4 +85,4 @@ function test()

<p>Tests to make sure the proper view is used for the data that is received in network panel.</p>

</body>

-</html>

+</html>