Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1354)

Unified Diff: runtime/vm/constants_dbc.h

Issue 2109743002: DBC: Implement InstanceOf. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: . Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/constants_dbc.h
diff --git a/runtime/vm/constants_dbc.h b/runtime/vm/constants_dbc.h
index 4f8aab93ec22373f9d82a148e12da85e519ef39f..fa0f42f3bae0e596d5d6365d16cf31fb74558f4f 100644
--- a/runtime/vm/constants_dbc.h
+++ b/runtime/vm/constants_dbc.h
@@ -340,6 +340,11 @@ namespace dart {
//
// Instantiate type arguments PP[D] with instantiator SP[0].
//
+// - InstanceOf
+//
+// Test if instance SP[-3] with type arguments SP[-2] is a subtype of SP[-1]
+// using SubtypeTestCache SP[0].
+//
// - AssertAssignable D
//
// Assert that SP[-3] is assignable to variable named SP[0] of type
@@ -469,6 +474,7 @@ namespace dart {
V(StoreStaticTOS, D, lit, ___, ___) \
V(PushStatic, D, lit, ___, ___) \
V(InitStaticTOS, 0, ___, ___, ___) \
+ V(LogicalNot, 0, ___, ___, ___) \
zra 2016/06/28 19:28:05 Already have BooleanNegate{TOS}.
rmacnak 2016/06/28 21:21:50 Ahh
V(IfNeStrictTOS, 0, ___, ___, ___) \
V(IfEqStrictTOS, 0, ___, ___, ___) \
V(IfNeStrictNumTOS, 0, ___, ___, ___) \
@@ -499,6 +505,7 @@ namespace dart {
V(MoveSpecial, A_D, reg, num, ___) \
V(InstantiateType, D, lit, ___, ___) \
V(InstantiateTypeArgumentsTOS, A_D, num, lit, ___) \
+ V(InstanceOf, 0, ___, ___, ___) \
V(AssertAssignable, D, num, lit, ___) \
V(AssertBoolean, A, num, ___, ___) \
V(CheckSmi, A, reg, ___, ___) \

Powered by Google App Engine
This is Rietveld 408576698