Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Unified Diff: runtime/vm/code_generator.cc

Issue 2109743002: DBC: Implement InstanceOf. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: . Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/code_generator.cc
diff --git a/runtime/vm/code_generator.cc b/runtime/vm/code_generator.cc
index 683834bd328178fc4de2f6c62711713ec3a4bb6c..4c16a3ded58b7c09498b94ad4bcb9279ca0ff8d7 100644
--- a/runtime/vm/code_generator.cc
+++ b/runtime/vm/code_generator.cc
@@ -450,8 +450,10 @@ DEFINE_RUNTIME_ENTRY(Instanceof, 4) {
AbstractType::CheckedHandle(zone, arguments.ArgAt(1));
const TypeArguments& instantiator_type_arguments =
TypeArguments::CheckedHandle(zone, arguments.ArgAt(2));
+#if !defined(TARGET_ARCH_DBC)
zra 2016/06/28 19:28:04 It looks like you're passing the cache, so even th
rmacnak 2016/06/28 21:21:50 The update code is unhappy if it inserts duplicate
const SubtypeTestCache& cache =
SubtypeTestCache::CheckedHandle(zone, arguments.ArgAt(3));
+#endif
ASSERT(type.IsFinalized());
ASSERT(!type.IsMalformed()); // Already checked in code generator.
ASSERT(!type.IsMalbounded()); // Already checked in code generator.
@@ -475,8 +477,10 @@ DEFINE_RUNTIME_ENTRY(Instanceof, 4) {
Symbols::Empty(), bound_error_message);
UNREACHABLE();
}
+#if !defined(TARGET_ARCH_DBC)
UpdateTypeTestCache(
instance, type, instantiator_type_arguments, result, cache);
+#endif
arguments.SetReturn(result);
}

Powered by Google App Engine
This is Rietveld 408576698