chrome/browser/ui/views/website_settings/permissions_bubble_view.cc - Issue 2109663005: Permission prompts show in the top-left corner in fullscreen mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

Issue 2109663005: Permission prompts show in the top-left corner in fullscreen mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission-bubble-detach-from-fullscreen

Patch Set: Take into account RTL displays and multiple monitors. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/website_settings/permissions_bubble_view.h ('k') | chrome/browser/ui/views/website_settings/permissions_bubble_view_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

diff --git a/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc b/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

index 066900f7696c87c5e564b12879387c617e661c27..ca4619c541efde61e95c58f0fdbcbce56afd87bf 100644

--- a/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

+++ b/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

@@ -362,10 +362,9 @@ void PermissionsBubbleDialogDelegateView::UpdateAnchor(

new views::BubbleBorder(adjusted_arrow, shadow(), color())));

// Reposition the bubble based on the updated arrow and view.

- if (anchor_view)

- SetAnchorView(anchor_view);

- else

- SetAnchorRect(gfx::Rect(anchor_point, gfx::Size()));

+ SetAnchorView(anchor_view);

Matt Giuca 2016/07/05 05:44:20 This change was necessary to properly respond to t

benwells 2016/07/06 01:08:53 Acknowledged.

+ // The anchor rect is ignored unless |anchor_view| is nullptr.

+ SetAnchorRect(gfx::Rect(anchor_point, gfx::Size()));

}

//////////////////////////////////////////////////////////////////////////////